diff mbox series

[1/2] pinctrl: qcom-ssbi: add support for PM8901

Message ID 20240415141743.1983350-1-github.com@herrie.org
State New
Headers show
Series [1/2] pinctrl: qcom-ssbi: add support for PM8901 | expand

Commit Message

Herman van Hazendonk April 15, 2024, 2:17 p.m. UTC
The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
and HP TouchPad. It works the same as all others, so just add the
compatible string for this variant.

Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Baryshkov April 17, 2024, 7:05 a.m. UTC | #1
On Mon, 15 Apr 2024 at 17:28, Herman van Hazendonk
<github.com@herrie.org> wrote:
>
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
>  1 file changed, 1 insertion(+)

Subject should be "dt-bindings: pinctrl: qcom,pmic-mpp: ..... "

>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> index fe717d8d4798..43146709e204 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> @@ -35,6 +35,7 @@ properties:
>                - qcom,pm8038-mpp
>                - qcom,pm8058-mpp
>                - qcom,pm8821-mpp
> +              - qcom,pm8901-mpp
>                - qcom,pm8917-mpp
>                - qcom,pm8921-mpp
>            - const: qcom,ssbi-mpp
>
Linus Walleij April 17, 2024, 9:26 a.m. UTC | #2
On Mon, Apr 15, 2024 at 4:17 PM Herman van Hazendonk
<github.com@herrie.org> wrote:

> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>

Patch applied, fixing subject.

Yours,
Linus Walleij
Krzysztof Kozlowski April 17, 2024, 2:11 p.m. UTC | #3
On 15/04/2024 16:17, Herman van Hazendonk wrote:
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
> 
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
index fe717d8d4798..43146709e204 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
@@ -35,6 +35,7 @@  properties:
               - qcom,pm8038-mpp
               - qcom,pm8058-mpp
               - qcom,pm8821-mpp
+              - qcom,pm8901-mpp
               - qcom,pm8917-mpp
               - qcom,pm8921-mpp
           - const: qcom,ssbi-mpp