diff mbox series

[v2,4/5] pinctrl: qcom: sm7150: fix module autoloading

Message ID 20240411064614.7409-4-krzk@kernel.org
State New
Headers show
Series [v2,1/5] pinctrl: freescale: imx8ulp: fix module autoloading | expand

Commit Message

Krzysztof Kozlowski April 11, 2024, 6:46 a.m. UTC 
Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
based on the alias from of_device_id table.  Pin controllers are
considered core components, so usually they are built-in, however these
can be built and used as modules on some generic kernel.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes in v2:
1. Add ack
---
 drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 +
 1 file changed, 1 insertion(+)

Comments

AngeloGioacchino Del Regno April 11, 2024, 9:42 a.m. UTC | #1 
Il 11/04/24 08:46, Krzysztof Kozlowski ha scritto:
> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> based on the alias from of_device_id table.  Pin controllers are
> considered core components, so usually they are built-in, however these
> can be built and used as modules on some generic kernel.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 


Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Bjorn Andersson April 11, 2024, 3:44 p.m. UTC | #2 
On Thu, Apr 11, 2024 at 08:46:13AM +0200, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> based on the alias from of_device_id table.  Pin controllers are
> considered core components, so usually they are built-in, however these
> can be built and used as modules on some generic kernel.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 

Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Regards,
Bjorn

> ---
> 
> Changes in v2:
> 1. Add ack
> ---
>  drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm7150.c b/drivers/pinctrl/qcom/pinctrl-sm7150.c
> index c25357ca1963..c542f9bc6bcd 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm7150.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm7150.c
> @@ -1246,6 +1246,7 @@ static const struct of_device_id sm7150_tlmm_of_match[] = {
>  	{ .compatible = "qcom,sm7150-tlmm", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match);
>  
>  static struct platform_driver sm7150_tlmm_driver = {
>  	.driver = {
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-sm7150.c b/drivers/pinctrl/qcom/pinctrl-sm7150.c
index c25357ca1963..c542f9bc6bcd 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm7150.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm7150.c
@@ -1246,6 +1246,7 @@  static const struct of_device_id sm7150_tlmm_of_match[] = {
 	{ .compatible = "qcom,sm7150-tlmm", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match);
 
 static struct platform_driver sm7150_tlmm_driver = {
 	.driver = {