| Message ID | 20240305-fix-aw9523-v1-1-97205563645b@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: aw9523: Fix I2C=y dependency | expand |
Hi Linus, On Tue, Mar 5, 2024 at 11:29 AM Linus Walleij <linus.walleij@linaro.org> wrote: > The AW9523 driver fails to build in some allmod configs since the > I2C core can be a module, but AW9523 can not. Fix it up so we depend > on I2C being compiled-in. > > Fixes: a4f15a8d4c82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202403050916.KBtE6eEj-lkp@intel.com/ > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Thanks for your patch! > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -129,7 +129,7 @@ config PINCTRL_AXP209 > > config PINCTRL_AW9523 > bool "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver" > - depends on OF && I2C > + depends on OF && I2C=y > select PINMUX > select PINCONF > select GENERIC_PINCONF Any reason PINCTRL_AW9523 cannot be tristate? The driver goes to great lengths to support removal. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 21d38bf2d1ca..a273a9b03122 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -129,7 +129,7 @@ config PINCTRL_AXP209 config PINCTRL_AW9523 bool "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver" - depends on OF && I2C + depends on OF && I2C=y select PINMUX select PINCONF select GENERIC_PINCONF
The AW9523 driver fails to build in some allmod configs since the I2C core can be a module, but AW9523 can not. Fix it up so we depend on I2C being compiled-in. Fixes: a4f15a8d4c82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander") Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202403050916.KBtE6eEj-lkp@intel.com/ Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: a4f15a8d4c8253d44830731d99be869d273c0c82 change-id: 20240305-fix-aw9523-4006b88f7b55 Best regards,