| Message ID | 20240223093701.66034-10-bhargav.r@ltts.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for TI TPS65224 PMIC | expand |
On 2/23/24 10:36, Bhargav Raviprakash wrote: > The reversion check is only applicable on TPS6594 family of PMICs. > Conditionally add that check if the chip_id is one of the PMIC in > the TPS6594 family. > > Signed-off-by: Bhargav Raviprakash <bhargav.r@ltts.com> > --- > drivers/misc/tps6594-esm.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) Following my comment related to ESM_MCU interrupts for 'tps6594.h': Does it really make sense to add tps65224 ESM_MCU support in linux ? For tps6594. TI requested a linux driver for ESM_SOC only (the "main" ESM). No linux driver was requested for ESM_MCU. Since tps65224 does not have ESM_SOC, I'm not sure that anything should be done in linux for tps65224 ESM. Maybe you should discuss this point with TI analog team (our TI contact for tps6594 was Chris Sterzik). Julien
diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c index b4d67a1a2..8ec5af9dc 100644 --- a/drivers/misc/tps6594-esm.c +++ b/drivers/misc/tps6594-esm.c @@ -45,13 +45,17 @@ static int tps6594_esm_probe(struct platform_device *pdev) * As a consequence, ESM can not be used on those PMIC. * Check the version and return an error in case of revision 1. */ - ret = regmap_read(tps->regmap, TPS6594_REG_DEV_REV, &rev); - if (ret) - return dev_err_probe(dev, ret, - "Failed to read PMIC revision\n"); - if (rev == TPS6594_DEV_REV_1) - return dev_err_probe(dev, -ENODEV, - "ESM not supported for revision 1 PMIC\n"); + if (tps->chip_id == TPS6594 || + tps->chip_id == TPS6593 || + tps->chip_id == LP8764) { + ret = regmap_read(tps->regmap, TPS6594_REG_DEV_REV, &rev); + if (ret) + return dev_err_probe(dev, ret, + "Failed to read PMIC revision\n"); + if (rev == TPS6594_DEV_REV_1) + return dev_err_probe(dev, -ENODEV, + "ESM not supported for revision 1 PMIC\n"); + } for (i = 0; i < pdev->num_resources; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name);
The reversion check is only applicable on TPS6594 family of PMICs. Conditionally add that check if the chip_id is one of the PMIC in the TPS6594 family. Signed-off-by: Bhargav Raviprakash <bhargav.r@ltts.com> --- drivers/misc/tps6594-esm.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)