| Message ID | 20231130024046.25938-4-quic_tengfan@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctl: qcom: sm4450: Add SM4450 pinctrl driver | expand |
On 30.11.2023 03:40, Tengfei Fan wrote: > Use .remove_new() instead of .remove() for converting to platform remove > callback returning void. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- You misunderstood me, this series now introduces a driver with known issues and patches them up right away in subsequent changes. What you should do in such situations is squash the fixups into the newly added driver (e.g. by running git rebase -i baseofyourtree and changing 'pick' to 'f' (for 'fixup') on the last two patches). Konrad
在 11/30/2023 6:36 PM, Konrad Dybcio 写道: > On 30.11.2023 03:40, Tengfei Fan wrote: >> Use .remove_new() instead of .remove() for converting to platform remove >> callback returning void. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- > You misunderstood me, this series now introduces a driver with known > issues and patches them up right away in subsequent changes. > > What you should do in such situations is squash the fixups into the > newly added driver (e.g. by running git rebase -i baseofyourtree and > changing 'pick' to 'f' (for 'fixup') on the last two patches). > > Konrad > > I understand what you meain, I should combine these two fix patches and the driver patch into a complete patch.
diff --git a/drivers/pinctrl/qcom/pinctrl-sm4450.c b/drivers/pinctrl/qcom/pinctrl-sm4450.c index 20ad639087ed..49e2e3a7a9cb 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm4450.c +++ b/drivers/pinctrl/qcom/pinctrl-sm4450.c @@ -993,7 +993,7 @@ static struct platform_driver sm4450_tlmm_driver = { .of_match_table = sm4450_tlmm_of_match, }, .probe = sm4450_tlmm_probe, - .remove = msm_pinctrl_remove, + .remove_new = msm_pinctrl_remove, }; MODULE_DEVICE_TABLE(of, sm4450_tlmm_of_match);
Use .remove_new() instead of .remove() for converting to platform remove callback returning void. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- drivers/pinctrl/qcom/pinctrl-sm4450.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)