| Message ID | 20231120193353.1670732-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [rft,v1,1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup | expand |
Hi Andy, kernel test robot noticed the following build warnings: [auto build test WARNING on linusw-pinctrl/devel] [also build test WARNING on linusw-pinctrl/for-next linus/master v6.7-rc2 next-20231120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-qcom-lpass-lpi-Remove-unused-member-in-struct-lpi_pingroup/20231121-034448 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel patch link: https://lore.kernel.org/r/20231120193353.1670732-1-andriy.shevchenko%40linux.intel.com patch subject: [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20231121/202311210748.H9kflJ6K-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311210748.H9kflJ6K-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311210748.H9kflJ6K-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:55:12: warning: unused variable 'gpio0_pins' [-Wunused-variable] static int gpio0_pins[] = { 0 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:56:12: warning: unused variable 'gpio1_pins' [-Wunused-variable] static int gpio1_pins[] = { 1 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:57:12: warning: unused variable 'gpio2_pins' [-Wunused-variable] static int gpio2_pins[] = { 2 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:58:12: warning: unused variable 'gpio3_pins' [-Wunused-variable] static int gpio3_pins[] = { 3 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:59:12: warning: unused variable 'gpio4_pins' [-Wunused-variable] static int gpio4_pins[] = { 4 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:60:12: warning: unused variable 'gpio5_pins' [-Wunused-variable] static int gpio5_pins[] = { 5 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:61:12: warning: unused variable 'gpio6_pins' [-Wunused-variable] static int gpio6_pins[] = { 6 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:62:12: warning: unused variable 'gpio7_pins' [-Wunused-variable] static int gpio7_pins[] = { 7 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:63:12: warning: unused variable 'gpio8_pins' [-Wunused-variable] static int gpio8_pins[] = { 8 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:64:12: warning: unused variable 'gpio9_pins' [-Wunused-variable] static int gpio9_pins[] = { 9 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:65:12: warning: unused variable 'gpio10_pins' [-Wunused-variable] static int gpio10_pins[] = { 10 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:66:12: warning: unused variable 'gpio11_pins' [-Wunused-variable] static int gpio11_pins[] = { 11 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:67:12: warning: unused variable 'gpio12_pins' [-Wunused-variable] static int gpio12_pins[] = { 12 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:68:12: warning: unused variable 'gpio13_pins' [-Wunused-variable] static int gpio13_pins[] = { 13 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:69:12: warning: unused variable 'gpio14_pins' [-Wunused-variable] static int gpio14_pins[] = { 14 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:70:12: warning: unused variable 'gpio15_pins' [-Wunused-variable] static int gpio15_pins[] = { 15 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:71:12: warning: unused variable 'gpio16_pins' [-Wunused-variable] static int gpio16_pins[] = { 16 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:72:12: warning: unused variable 'gpio17_pins' [-Wunused-variable] static int gpio17_pins[] = { 17 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:73:12: warning: unused variable 'gpio18_pins' [-Wunused-variable] static int gpio18_pins[] = { 18 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:74:12: warning: unused variable 'gpio19_pins' [-Wunused-variable] static int gpio19_pins[] = { 19 }; ^ drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:75:12: warning: unused variable 'gpio20_pins' [-Wunused-variable] static int gpio20_pins[] = { 20 }; ^ drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:76:12: warning: unused variable 'gpio21_pins' [-Wunused-variable] static int gpio21_pins[] = { 21 }; ^ drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:77:12: warning: unused variable 'gpio22_pins' [-Wunused-variable] static int gpio22_pins[] = { 22 }; ^ 23 warnings generated. -- >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:57:12: warning: unused variable 'gpio0_pins' [-Wunused-variable] static int gpio0_pins[] = { 0 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:58:12: warning: unused variable 'gpio1_pins' [-Wunused-variable] static int gpio1_pins[] = { 1 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:59:12: warning: unused variable 'gpio2_pins' [-Wunused-variable] static int gpio2_pins[] = { 2 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:60:12: warning: unused variable 'gpio3_pins' [-Wunused-variable] static int gpio3_pins[] = { 3 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:61:12: warning: unused variable 'gpio4_pins' [-Wunused-variable] static int gpio4_pins[] = { 4 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:62:12: warning: unused variable 'gpio5_pins' [-Wunused-variable] static int gpio5_pins[] = { 5 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:63:12: warning: unused variable 'gpio6_pins' [-Wunused-variable] static int gpio6_pins[] = { 6 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:64:12: warning: unused variable 'gpio7_pins' [-Wunused-variable] static int gpio7_pins[] = { 7 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:65:12: warning: unused variable 'gpio8_pins' [-Wunused-variable] static int gpio8_pins[] = { 8 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:66:12: warning: unused variable 'gpio9_pins' [-Wunused-variable] static int gpio9_pins[] = { 9 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:67:12: warning: unused variable 'gpio10_pins' [-Wunused-variable] static int gpio10_pins[] = { 10 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:68:12: warning: unused variable 'gpio11_pins' [-Wunused-variable] static int gpio11_pins[] = { 11 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:69:12: warning: unused variable 'gpio12_pins' [-Wunused-variable] static int gpio12_pins[] = { 12 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:70:12: warning: unused variable 'gpio13_pins' [-Wunused-variable] static int gpio13_pins[] = { 13 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:71:12: warning: unused variable 'gpio14_pins' [-Wunused-variable] static int gpio14_pins[] = { 14 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:72:12: warning: unused variable 'gpio15_pins' [-Wunused-variable] static int gpio15_pins[] = { 15 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:73:12: warning: unused variable 'gpio16_pins' [-Wunused-variable] static int gpio16_pins[] = { 16 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:74:12: warning: unused variable 'gpio17_pins' [-Wunused-variable] static int gpio17_pins[] = { 17 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:75:12: warning: unused variable 'gpio18_pins' [-Wunused-variable] static int gpio18_pins[] = { 18 }; ^ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:76:12: warning: unused variable 'gpio19_pins' [-Wunused-variable] static int gpio19_pins[] = { 19 }; ^ drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:77:12: warning: unused variable 'gpio20_pins' [-Wunused-variable] static int gpio20_pins[] = { 20 }; ^ drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:78:12: warning: unused variable 'gpio21_pins' [-Wunused-variable] static int gpio21_pins[] = { 21 }; ^ drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:79:12: warning: unused variable 'gpio22_pins' [-Wunused-variable] static int gpio22_pins[] = { 22 }; ^ 23 warnings generated. vim +/gpio0_pins +55 drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 54 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @55 static int gpio0_pins[] = { 0 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @56 static int gpio1_pins[] = { 1 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @57 static int gpio2_pins[] = { 2 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @58 static int gpio3_pins[] = { 3 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @59 static int gpio4_pins[] = { 4 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @60 static int gpio5_pins[] = { 5 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @61 static int gpio6_pins[] = { 6 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @62 static int gpio7_pins[] = { 7 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @63 static int gpio8_pins[] = { 8 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @64 static int gpio9_pins[] = { 9 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @65 static int gpio10_pins[] = { 10 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @66 static int gpio11_pins[] = { 11 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @67 static int gpio12_pins[] = { 12 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @68 static int gpio13_pins[] = { 13 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @69 static int gpio14_pins[] = { 14 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @70 static int gpio15_pins[] = { 15 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @71 static int gpio16_pins[] = { 16 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @72 static int gpio17_pins[] = { 17 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @73 static int gpio18_pins[] = { 18 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @74 static int gpio19_pins[] = { 19 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @75 static int gpio20_pins[] = { 20 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @76 static int gpio21_pins[] = { 21 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @77 static int gpio22_pins[] = { 22 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 78
Hi Andy, kernel test robot noticed the following build warnings: [auto build test WARNING on linusw-pinctrl/devel] [also build test WARNING on linusw-pinctrl/for-next linus/master v6.7-rc2 next-20231120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-qcom-lpass-lpi-Remove-unused-member-in-struct-lpi_pingroup/20231121-034448 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel patch link: https://lore.kernel.org/r/20231120193353.1670732-1-andriy.shevchenko%40linux.intel.com patch subject: [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup config: x86_64-buildonly-randconfig-001-20231121 (https://download.01.org/0day-ci/archive/20231121/202311211148.TRaoiPGX-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311211148.TRaoiPGX-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311211148.TRaoiPGX-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:77:12: warning: 'gpio22_pins' defined but not used [-Wunused-variable] 77 | static int gpio22_pins[] = { 22 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:76:12: warning: 'gpio21_pins' defined but not used [-Wunused-variable] 76 | static int gpio21_pins[] = { 21 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:75:12: warning: 'gpio20_pins' defined but not used [-Wunused-variable] 75 | static int gpio20_pins[] = { 20 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:74:12: warning: 'gpio19_pins' defined but not used [-Wunused-variable] 74 | static int gpio19_pins[] = { 19 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:73:12: warning: 'gpio18_pins' defined but not used [-Wunused-variable] 73 | static int gpio18_pins[] = { 18 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:72:12: warning: 'gpio17_pins' defined but not used [-Wunused-variable] 72 | static int gpio17_pins[] = { 17 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:71:12: warning: 'gpio16_pins' defined but not used [-Wunused-variable] 71 | static int gpio16_pins[] = { 16 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:70:12: warning: 'gpio15_pins' defined but not used [-Wunused-variable] 70 | static int gpio15_pins[] = { 15 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:69:12: warning: 'gpio14_pins' defined but not used [-Wunused-variable] 69 | static int gpio14_pins[] = { 14 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:68:12: warning: 'gpio13_pins' defined but not used [-Wunused-variable] 68 | static int gpio13_pins[] = { 13 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:67:12: warning: 'gpio12_pins' defined but not used [-Wunused-variable] 67 | static int gpio12_pins[] = { 12 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:66:12: warning: 'gpio11_pins' defined but not used [-Wunused-variable] 66 | static int gpio11_pins[] = { 11 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:65:12: warning: 'gpio10_pins' defined but not used [-Wunused-variable] 65 | static int gpio10_pins[] = { 10 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:64:12: warning: 'gpio9_pins' defined but not used [-Wunused-variable] 64 | static int gpio9_pins[] = { 9 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:63:12: warning: 'gpio8_pins' defined but not used [-Wunused-variable] 63 | static int gpio8_pins[] = { 8 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:62:12: warning: 'gpio7_pins' defined but not used [-Wunused-variable] 62 | static int gpio7_pins[] = { 7 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:61:12: warning: 'gpio6_pins' defined but not used [-Wunused-variable] 61 | static int gpio6_pins[] = { 6 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:60:12: warning: 'gpio5_pins' defined but not used [-Wunused-variable] 60 | static int gpio5_pins[] = { 5 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:59:12: warning: 'gpio4_pins' defined but not used [-Wunused-variable] 59 | static int gpio4_pins[] = { 4 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:58:12: warning: 'gpio3_pins' defined but not used [-Wunused-variable] 58 | static int gpio3_pins[] = { 3 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:57:12: warning: 'gpio2_pins' defined but not used [-Wunused-variable] 57 | static int gpio2_pins[] = { 2 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:56:12: warning: 'gpio1_pins' defined but not used [-Wunused-variable] 56 | static int gpio1_pins[] = { 1 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c:55:12: warning: 'gpio0_pins' defined but not used [-Wunused-variable] 55 | static int gpio0_pins[] = { 0 }; | ^~~~~~~~~~ -- >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:79:12: warning: 'gpio22_pins' defined but not used [-Wunused-variable] 79 | static int gpio22_pins[] = { 22 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:78:12: warning: 'gpio21_pins' defined but not used [-Wunused-variable] 78 | static int gpio21_pins[] = { 21 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:77:12: warning: 'gpio20_pins' defined but not used [-Wunused-variable] 77 | static int gpio20_pins[] = { 20 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:76:12: warning: 'gpio19_pins' defined but not used [-Wunused-variable] 76 | static int gpio19_pins[] = { 19 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:75:12: warning: 'gpio18_pins' defined but not used [-Wunused-variable] 75 | static int gpio18_pins[] = { 18 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:74:12: warning: 'gpio17_pins' defined but not used [-Wunused-variable] 74 | static int gpio17_pins[] = { 17 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:73:12: warning: 'gpio16_pins' defined but not used [-Wunused-variable] 73 | static int gpio16_pins[] = { 16 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:72:12: warning: 'gpio15_pins' defined but not used [-Wunused-variable] 72 | static int gpio15_pins[] = { 15 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:71:12: warning: 'gpio14_pins' defined but not used [-Wunused-variable] 71 | static int gpio14_pins[] = { 14 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:70:12: warning: 'gpio13_pins' defined but not used [-Wunused-variable] 70 | static int gpio13_pins[] = { 13 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:69:12: warning: 'gpio12_pins' defined but not used [-Wunused-variable] 69 | static int gpio12_pins[] = { 12 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:68:12: warning: 'gpio11_pins' defined but not used [-Wunused-variable] 68 | static int gpio11_pins[] = { 11 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:67:12: warning: 'gpio10_pins' defined but not used [-Wunused-variable] 67 | static int gpio10_pins[] = { 10 }; | ^~~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:66:12: warning: 'gpio9_pins' defined but not used [-Wunused-variable] 66 | static int gpio9_pins[] = { 9 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:65:12: warning: 'gpio8_pins' defined but not used [-Wunused-variable] 65 | static int gpio8_pins[] = { 8 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:64:12: warning: 'gpio7_pins' defined but not used [-Wunused-variable] 64 | static int gpio7_pins[] = { 7 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:63:12: warning: 'gpio6_pins' defined but not used [-Wunused-variable] 63 | static int gpio6_pins[] = { 6 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:62:12: warning: 'gpio5_pins' defined but not used [-Wunused-variable] 62 | static int gpio5_pins[] = { 5 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:61:12: warning: 'gpio4_pins' defined but not used [-Wunused-variable] 61 | static int gpio4_pins[] = { 4 }; | ^~~~~~~~~~ >> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:60:12: warning: 'gpio3_pins' defined but not used [-Wunused-variable] 60 | static int gpio3_pins[] = { 3 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:59:12: warning: 'gpio2_pins' defined but not used [-Wunused-variable] 59 | static int gpio2_pins[] = { 2 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:58:12: warning: 'gpio1_pins' defined but not used [-Wunused-variable] 58 | static int gpio1_pins[] = { 1 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:57:12: warning: 'gpio0_pins' defined but not used [-Wunused-variable] 57 | static int gpio0_pins[] = { 0 }; | ^~~~~~~~~~ vim +/gpio22_pins +77 drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 54 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @55 static int gpio0_pins[] = { 0 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @56 static int gpio1_pins[] = { 1 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @57 static int gpio2_pins[] = { 2 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @58 static int gpio3_pins[] = { 3 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @59 static int gpio4_pins[] = { 4 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @60 static int gpio5_pins[] = { 5 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @61 static int gpio6_pins[] = { 6 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @62 static int gpio7_pins[] = { 7 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @63 static int gpio8_pins[] = { 8 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @64 static int gpio9_pins[] = { 9 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @65 static int gpio10_pins[] = { 10 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @66 static int gpio11_pins[] = { 11 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @67 static int gpio12_pins[] = { 12 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @68 static int gpio13_pins[] = { 13 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @69 static int gpio14_pins[] = { 14 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @70 static int gpio15_pins[] = { 15 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @71 static int gpio16_pins[] = { 16 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @72 static int gpio17_pins[] = { 17 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @73 static int gpio18_pins[] = { 18 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @74 static int gpio19_pins[] = { 19 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @75 static int gpio20_pins[] = { 20 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @76 static int gpio21_pins[] = { 21 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 @77 static int gpio22_pins[] = { 22 }; 5a6ca1f240d6a2 Krzysztof Kozlowski 2023-02-03 78
On 20/11/2023 20:26, Andy Shevchenko wrote: > The group is not used anywhere, remove it. And if needed, it should be > struct pingroup anyway. > > While at it, replace kernel.h with what exactly being used. Missing Reported-by and Closes by for LKP... Unless you discovered it without its report? > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > > _Seems_ like this (I only read the code), hence rft. > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 6 +---- > .../pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 16 ------------- > .../pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c | 20 ---------------- > .../pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c | 20 ---------------- > .../pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 15 ------------ > .../pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c | 16 ------------- > .../pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c | 24 ------------------- Missing sm8550. > 7 files changed, 1 insertion(+), 116 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h > index 206b2c0ca828..a9b2f65c1ebe 100644 > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h > @@ -6,8 +6,8 @@ > #ifndef __PINCTRL_LPASS_LPI_H__ > #define __PINCTRL_LPASS_LPI_H__ > > +#include <linux/array_size.h> > #include <linux/bits.h> > -#include <linux/kernel.h> > > #include "../core.h" > > @@ -45,11 +45,8 @@ struct pinctrl_pin_desc; > > #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \ > { \ > - .group.name = "gpio" #id, \ > - .group.pins = gpio##id##_pins, \ Aren't these used by core pinctrl code? Best regards, Krzysztof
On Tue, Nov 21, 2023 at 08:14:09AM +0100, Krzysztof Kozlowski wrote: > On 20/11/2023 20:26, Andy Shevchenko wrote: > > The group is not used anywhere, remove it. And if needed, it should be > > struct pingroup anyway. > > > > While at it, replace kernel.h with what exactly being used. > > Missing Reported-by and Closes by for LKP... Unless you discovered it > without its report? It's just at hand discovery. > Missing sm8550. And sm8650, but there LPI_FUNCTION(gpio) and I'm wondering why LKP complains about it. It's really a maze to me. > > #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \ > > { \ > > - .group.name = "gpio" #id, \ > > - .group.pins = gpio##id##_pins, \ > > Aren't these used by core pinctrl code? Only via APIs and pin control registered them also via APIs, so I don't think this is being used directly. But if you see how, tell me! I spent already a few hours on this and haven't got any clear picture in my mind.
On Tue, Nov 21, 2023 at 07:15:33PM +0200, Andy Shevchenko wrote: > On Tue, Nov 21, 2023 at 08:14:09AM +0100, Krzysztof Kozlowski wrote: > > On 20/11/2023 20:26, Andy Shevchenko wrote: > > > The group is not used anywhere, remove it. And if needed, it should be > > > struct pingroup anyway. > > > > > > While at it, replace kernel.h with what exactly being used. > > > > Missing Reported-by and Closes by for LKP... Unless you discovered it > > without its report? > > It's just at hand discovery. > > > Missing sm8550. > > And sm8650, but there LPI_FUNCTION(gpio) and I'm wondering why LKP complains > about it. It's really a maze to me. Ah, this is _pins, _groups is still in use. Okay, I will remove that in next version. > > > #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \ > > > { \ > > > - .group.name = "gpio" #id, \ > > > - .group.pins = gpio##id##_pins, \ > > > > Aren't these used by core pinctrl code? > > Only via APIs and pin control registered them also via APIs, so I don't think > this is being used directly. But if you see how, tell me! I spent already a few > hours on this and haven't got any clear picture in my mind.
diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h index 206b2c0ca828..a9b2f65c1ebe 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h @@ -6,8 +6,8 @@ #ifndef __PINCTRL_LPASS_LPI_H__ #define __PINCTRL_LPASS_LPI_H__ +#include <linux/array_size.h> #include <linux/bits.h> -#include <linux/kernel.h> #include "../core.h" @@ -45,11 +45,8 @@ struct pinctrl_pin_desc; #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \ { \ - .group.name = "gpio" #id, \ - .group.pins = gpio##id##_pins, \ .pin = id, \ .slew_offset = soff, \ - .group.num_pins = ARRAY_SIZE(gpio##id##_pins), \ .funcs = (int[]){ \ LPI_MUX_gpio, \ LPI_MUX_##f1, \ @@ -67,7 +64,6 @@ struct pinctrl_pin_desc; #define LPI_FLAG_SLEW_RATE_SAME_REG BIT(0) struct lpi_pingroup { - struct group_desc group; unsigned int pin; /* Bit offset in slew register for SoundWire pins only */ int slew_offset; diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c index 99156217c6a5..6bb39812e1d8 100644 --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c @@ -36,22 +36,6 @@ enum lpass_lpi_functions { LPI_MUX__, }; -static int gpio0_pins[] = { 0 }; -static int gpio1_pins[] = { 1 }; -static int gpio2_pins[] = { 2 }; -static int gpio3_pins[] = { 3 }; -static int gpio4_pins[] = { 4 }; -static int gpio5_pins[] = { 5 }; -static int gpio6_pins[] = { 6 }; -static int gpio7_pins[] = { 7 }; -static int gpio8_pins[] = { 8 }; -static int gpio9_pins[] = { 9 }; -static int gpio10_pins[] = { 10 }; -static int gpio11_pins[] = { 11 }; -static int gpio12_pins[] = { 12 }; -static int gpio13_pins[] = { 13 }; -static int gpio14_pins[] = { 14 }; - static const struct pinctrl_pin_desc sc7280_lpi_pins[] = { PINCTRL_PIN(0, "gpio0"), PINCTRL_PIN(1, "gpio1"), diff --git a/drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c index b33483056f42..c0369baf3398 100644 --- a/drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c @@ -45,26 +45,6 @@ enum lpass_lpi_functions { LPI_MUX__, }; -static int gpio0_pins[] = { 0 }; -static int gpio1_pins[] = { 1 }; -static int gpio2_pins[] = { 2 }; -static int gpio3_pins[] = { 3 }; -static int gpio4_pins[] = { 4 }; -static int gpio5_pins[] = { 5 }; -static int gpio6_pins[] = { 6 }; -static int gpio7_pins[] = { 7 }; -static int gpio8_pins[] = { 8 }; -static int gpio9_pins[] = { 9 }; -static int gpio10_pins[] = { 10 }; -static int gpio11_pins[] = { 11 }; -static int gpio12_pins[] = { 12 }; -static int gpio13_pins[] = { 13 }; -static int gpio14_pins[] = { 14 }; -static int gpio15_pins[] = { 15 }; -static int gpio16_pins[] = { 16 }; -static int gpio17_pins[] = { 17 }; -static int gpio18_pins[] = { 18 }; - static const struct pinctrl_pin_desc sc8280xp_lpi_pins[] = { PINCTRL_PIN(0, "gpio0"), PINCTRL_PIN(1, "gpio1"), diff --git a/drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c index e8a6f6f6af54..316d6fc69131 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c @@ -36,26 +36,6 @@ enum lpass_lpi_functions { LPI_MUX__, }; -static int gpio0_pins[] = { 0 }; -static int gpio1_pins[] = { 1 }; -static int gpio2_pins[] = { 2 }; -static int gpio3_pins[] = { 3 }; -static int gpio4_pins[] = { 4 }; -static int gpio5_pins[] = { 5 }; -static int gpio6_pins[] = { 6 }; -static int gpio7_pins[] = { 7 }; -static int gpio8_pins[] = { 8 }; -static int gpio9_pins[] = { 9 }; -static int gpio10_pins[] = { 10 }; -static int gpio11_pins[] = { 11 }; -static int gpio12_pins[] = { 12 }; -static int gpio13_pins[] = { 13 }; -static int gpio14_pins[] = { 14 }; -static int gpio15_pins[] = { 15 }; -static int gpio16_pins[] = { 16 }; -static int gpio17_pins[] = { 17 }; -static int gpio18_pins[] = { 18 }; - static const struct pinctrl_pin_desc sm6115_lpi_pins[] = { PINCTRL_PIN(0, "gpio0"), PINCTRL_PIN(1, "gpio1"), diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c index cb10ce8d5d28..9791d9ba5087 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c @@ -36,21 +36,6 @@ enum lpass_lpi_functions { LPI_MUX__, }; -static int gpio0_pins[] = { 0 }; -static int gpio1_pins[] = { 1 }; -static int gpio2_pins[] = { 2 }; -static int gpio3_pins[] = { 3 }; -static int gpio4_pins[] = { 4 }; -static int gpio5_pins[] = { 5 }; -static int gpio6_pins[] = { 6 }; -static int gpio7_pins[] = { 7 }; -static int gpio8_pins[] = { 8 }; -static int gpio9_pins[] = { 9 }; -static int gpio10_pins[] = { 10 }; -static int gpio11_pins[] = { 11 }; -static int gpio12_pins[] = { 12 }; -static int gpio13_pins[] = { 13 }; - static const struct pinctrl_pin_desc sm8250_lpi_pins[] = { PINCTRL_PIN(0, "gpio0"), PINCTRL_PIN(1, "gpio1"), diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c index 297cc95ac3c0..5b9a2cb216bd 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c @@ -36,22 +36,6 @@ enum lpass_lpi_functions { LPI_MUX__, }; -static int gpio0_pins[] = { 0 }; -static int gpio1_pins[] = { 1 }; -static int gpio2_pins[] = { 2 }; -static int gpio3_pins[] = { 3 }; -static int gpio4_pins[] = { 4 }; -static int gpio5_pins[] = { 5 }; -static int gpio6_pins[] = { 6 }; -static int gpio7_pins[] = { 7 }; -static int gpio8_pins[] = { 8 }; -static int gpio9_pins[] = { 9 }; -static int gpio10_pins[] = { 10 }; -static int gpio11_pins[] = { 11 }; -static int gpio12_pins[] = { 12 }; -static int gpio13_pins[] = { 13 }; -static int gpio14_pins[] = { 14 }; - static const struct pinctrl_pin_desc sm8350_lpi_pins[] = { PINCTRL_PIN(0, "gpio0"), PINCTRL_PIN(1, "gpio1"), diff --git a/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c index 2e7896791fc0..a028cbb49947 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c @@ -52,30 +52,6 @@ enum lpass_lpi_functions { LPI_MUX__, }; -static int gpio0_pins[] = { 0 }; -static int gpio1_pins[] = { 1 }; -static int gpio2_pins[] = { 2 }; -static int gpio3_pins[] = { 3 }; -static int gpio4_pins[] = { 4 }; -static int gpio5_pins[] = { 5 }; -static int gpio6_pins[] = { 6 }; -static int gpio7_pins[] = { 7 }; -static int gpio8_pins[] = { 8 }; -static int gpio9_pins[] = { 9 }; -static int gpio10_pins[] = { 10 }; -static int gpio11_pins[] = { 11 }; -static int gpio12_pins[] = { 12 }; -static int gpio13_pins[] = { 13 }; -static int gpio14_pins[] = { 14 }; -static int gpio15_pins[] = { 15 }; -static int gpio16_pins[] = { 16 }; -static int gpio17_pins[] = { 17 }; -static int gpio18_pins[] = { 18 }; -static int gpio19_pins[] = { 19 }; -static int gpio20_pins[] = { 20 }; -static int gpio21_pins[] = { 21 }; -static int gpio22_pins[] = { 22 }; - static const struct pinctrl_pin_desc sm8450_lpi_pins[] = { PINCTRL_PIN(0, "gpio0"), PINCTRL_PIN(1, "gpio1"),
The group is not used anywhere, remove it. And if needed, it should be struct pingroup anyway. While at it, replace kernel.h with what exactly being used. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- _Seems_ like this (I only read the code), hence rft. drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 6 +---- .../pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 16 ------------- .../pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c | 20 ---------------- .../pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c | 20 ---------------- .../pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 15 ------------ .../pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c | 16 ------------- .../pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c | 24 ------------------- 7 files changed, 1 insertion(+), 116 deletions(-)