diff mbox series

gpio: mxc: set the port->irq high to 0 for imx2

Message ID 20230821031443.1443530-1-haibo.chen@nxp.com
State New
Headers show
Series gpio: mxc: set the port->irq high to 0 for imx2 | expand

Commit Message

Bough Chen Aug. 21, 2023, 3:14 a.m. UTC 
From: Haibo Chen <haibo.chen@nxp.com>

MX2 has one interrupt for all gpio ports, so do not need the value
port->irq_high, need to set to 0. Current setting is -1, which will
meet issue in gpio_set_wake_irq().

Fixes: 5f6d1998adeb ("gpio: mxc: release the parent IRQ in runtime suspend")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/gpio/gpio-mxc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Aug. 21, 2023, 11 a.m. UTC | #1 
On Mon, Aug 21, 2023 at 11:14:43AM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> MX2 has one interrupt for all gpio ports, so do not need the value
> port->irq_high, need to set to 0. Current setting is -1, which will
> meet issue in gpio_set_wake_irq().

Can you describe a bit more the nature of the issue?
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 004c6ad7ce52..c96602da7e3a 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -479,7 +479,7 @@  static int mxc_gpio_probe(struct platform_device *pdev)
 		 * the handler is needed only once, but doing it for every port
 		 * is more robust and easier.
 		 */
-		port->irq_high = -1;
+		port->irq_high = 0;
 		port->mx_irq_handler = mx2_gpio_irq_handler;
 	} else
 		port->mx_irq_handler = mx3_gpio_irq_handler;