| Message ID | 20230607095829.1345-1-jiasheng@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: npcm7xx: Add missing check for ioremap | expand |
Wed, Jun 07, 2023 at 05:58:29PM +0800, Jiasheng Jiang kirjoitti: > Add check for ioremap() and return the error if it fails in order to > guarantee the success of ioremap(). This one is correct, otherwise the GPIO is not functional at all. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c > index 21e61c2a3798..843ffcd96877 100644 > --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c > +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c > @@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl) > } > > pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res)); > + if (!pctrl->gpio_bank[id].base) > + return -EINVAL; > > ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4, > pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,
On Wed, Jun 7, 2023 at 11:58 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote: > Add check for ioremap() and return the error if it fails in order to > guarantee the success of ioremap(). > > Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Patch applied as nonurgent fix. Yours, Linus Walleij
diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c index 21e61c2a3798..843ffcd96877 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c @@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl) } pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res)); + if (!pctrl->gpio_bank[id].base) + return -EINVAL; ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4, pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,
Add check for ioremap() and return the error if it fails in order to guarantee the success of ioremap(). Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 ++ 1 file changed, 2 insertions(+)