| Message ID | 20230605125810.61456-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] gpiolib: Do not unexport GPIO on freeing | expand |
On Mon, Jun 5, 2023 at 2:58 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Since the legacy exporting is gone with 2f804aca4832 ("gpiolib: > Kill unused GPIOF_EXPORT and Co") there is no need to unexport > GPIO on freeing. Remove that call. > > Note, the other users of this functionality do that explicitly, > except one SH and one OMAP boardfile which don't free GPIO anyways, > so it is safe to drop the call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Yeah let's kill this off it is just annoying. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, Jun 5, 2023 at 2:58 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Since the legacy exporting is gone with 2f804aca4832 ("gpiolib: > Kill unused GPIOF_EXPORT and Co") there is no need to unexport > GPIO on freeing. Remove that call. > > Note, the other users of this functionality do that explicitly, > except one SH and one OMAP boardfile which don't free GPIO anyways, > so it is safe to drop the call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: mentioned OMAP boardfile as well > drivers/gpio/gpiolib.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index a8da38ee721a..7a9c9934365a 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2117,8 +2117,6 @@ static bool gpiod_free_commit(struct gpio_desc *desc) > > might_sleep(); > > - gpiod_unexport(desc); > - > spin_lock_irqsave(&gpio_lock, flags); > > gc = desc->gdev->chip; > -- > 2.40.0.1.gaa8946217a0b > Ah, you already sent a v2. I applied this one. Bart
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index a8da38ee721a..7a9c9934365a 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2117,8 +2117,6 @@ static bool gpiod_free_commit(struct gpio_desc *desc) might_sleep(); - gpiod_unexport(desc); - spin_lock_irqsave(&gpio_lock, flags); gc = desc->gdev->chip;
Since the legacy exporting is gone with 2f804aca4832 ("gpiolib: Kill unused GPIOF_EXPORT and Co") there is no need to unexport GPIO on freeing. Remove that call. Note, the other users of this functionality do that explicitly, except one SH and one OMAP boardfile which don't free GPIO anyways, so it is safe to drop the call. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: mentioned OMAP boardfile as well drivers/gpio/gpiolib.c | 2 -- 1 file changed, 2 deletions(-)