diff mbox series

[1/2] gpio: vf610: switch to dynamic allocat GPIO base

Message ID 20230506085928.933737-1-haibo.chen@nxp.com
State New
Headers show
Series [1/2] gpio: vf610: switch to dynamic allocat GPIO base | expand

Commit Message

Bough Chen May 6, 2023, 8:59 a.m. UTC 
From: Haibo Chen <haibo.chen@nxp.com>

gpiolib want to get completely rid of static gpiobase allocation,
so switch to dynamic allocat GPIO base, also can avoid warning
message:

[    1.529974] gpio gpiochip0: Static allocation of GPIO base
is deprecated, use dynamic allocation.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/gpio/gpio-vf610.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Linus Walleij May 6, 2023, 1:04 p.m. UTC | #1 
On Sat, May 6, 2023 at 10:56 AM <haibo.chen@nxp.com> wrote:

> From: Haibo Chen <haibo.chen@nxp.com>
>
> gpiolib want to get completely rid of static gpiobase allocation,
> so switch to dynamic allocat GPIO base, also can avoid warning
> message:
>
> [    1.529974] gpio gpiochip0: Static allocation of GPIO base
> is deprecated, use dynamic allocation.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bough Chen Aug. 21, 2023, 2:47 a.m. UTC | #2 
> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: 2023年5月6日 21:05
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: brgl@bgdev.pl; linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org;
> dl-linux-imx <linux-imx@nxp.com>; christophe.leroy@csgroup.eu
> Subject: Re: [PATCH 1/2] gpio: vf610: switch to dynamic allocat GPIO base
> 
> On Sat, May 6, 2023 at 10:56 AM <haibo.chen@nxp.com> wrote:
> 
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > gpiolib want to get completely rid of static gpiobase allocation, so
> > switch to dynamic allocat GPIO base, also can avoid warning
> > message:
> >
> > [    1.529974] gpio gpiochip0: Static allocation of GPIO base
> > is deprecated, use dynamic allocation.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Hi Linus and Bartosz,

For this patch, still not in the main trunk (Linux 6.5-rc7) and linux-next(next-20230818).
Can you help apply or any comment?

Best Regards
Haibo Chen

> 
> Yours,
> Linus Walleij
Bartosz Golaszewski Aug. 22, 2023, 9:39 a.m. UTC | #3 
On Mon, Aug 21, 2023 at 4:47 AM Bough Chen <haibo.chen@nxp.com> wrote:
>
> > -----Original Message-----
> > From: Linus Walleij <linus.walleij@linaro.org>
> > Sent: 2023年5月6日 21:05
> > To: Bough Chen <haibo.chen@nxp.com>
> > Cc: brgl@bgdev.pl; linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org;
> > dl-linux-imx <linux-imx@nxp.com>; christophe.leroy@csgroup.eu
> > Subject: Re: [PATCH 1/2] gpio: vf610: switch to dynamic allocat GPIO base
> >
> > On Sat, May 6, 2023 at 10:56 AM <haibo.chen@nxp.com> wrote:
> >
> > > From: Haibo Chen <haibo.chen@nxp.com>
> > >
> > > gpiolib want to get completely rid of static gpiobase allocation, so
> > > switch to dynamic allocat GPIO base, also can avoid warning
> > > message:
> > >
> > > [    1.529974] gpio gpiochip0: Static allocation of GPIO base
> > > is deprecated, use dynamic allocation.
> > >
> > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Hi Linus and Bartosz,
>
> For this patch, still not in the main trunk (Linux 6.5-rc7) and linux-next(next-20230818).
> Can you help apply or any comment?
>

I think I didn't apply it because the first patch in this series was
controversial with known user-space breakages. Now applied.

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index d3f3a69d4907..70e16cef7738 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -259,7 +259,6 @@  static void vf610_gpio_disable_clk(void *data)
 static int vf610_gpio_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
-	struct device_node *np = dev->of_node;
 	struct vf610_gpio_port *port;
 	struct gpio_chip *gc;
 	struct gpio_irq_chip *girq;
@@ -319,7 +318,7 @@  static int vf610_gpio_probe(struct platform_device *pdev)
 	gc->parent = dev;
 	gc->label = dev_name(dev);
 	gc->ngpio = VF610_GPIO_PER_PORT;
-	gc->base = of_alias_get_id(np, "gpio") * VF610_GPIO_PER_PORT;
+	gc->base = -1;
 
 	gc->request = gpiochip_generic_request;
 	gc->free = gpiochip_generic_free;