| Message ID | 20230224130828.27985-1-johan+linaro@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: at91-pio4: fix domain name assignment | expand |
On 24.02.2023 15:08, Johan Hovold wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Since commit d59f6617eef0 ("genirq: Allow fwnode to carry name > information only") an IRQ domain is always given a name during > allocation (e.g. used for the debugfs entry). > > Drop the no longer valid name assignment, which would lead to an attempt > to free a string constant when removing the domain on late probe > failures (e.g. probe deferral). > > Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only") > Cc: stable@vger.kernel.org # 4.13 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com> # on SAMA7G5 > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index 39b233f73e13..d699588677a5 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -1206,7 +1206,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev) > dev_err(dev, "can't add the irq domain\n"); > return -ENODEV; > } > - atmel_pioctrl->irq_domain->name = "atmel gpio"; > > for (i = 0; i < atmel_pioctrl->npins; i++) { > int irq = irq_create_mapping(atmel_pioctrl->irq_domain, i); > -- > 2.39.2 >
On Fri, Feb 24, 2023 at 2:09 PM Johan Hovold <johan+linaro@kernel.org> wrote: > Since commit d59f6617eef0 ("genirq: Allow fwnode to carry name > information only") an IRQ domain is always given a name during > allocation (e.g. used for the debugfs entry). > > Drop the no longer valid name assignment, which would lead to an attempt > to free a string constant when removing the domain on late probe > failures (e.g. probe deferral). > > Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only") > Cc: stable@vger.kernel.org # 4.13 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Thanks Johan, patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c index 39b233f73e13..d699588677a5 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -1206,7 +1206,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev) dev_err(dev, "can't add the irq domain\n"); return -ENODEV; } - atmel_pioctrl->irq_domain->name = "atmel gpio"; for (i = 0; i < atmel_pioctrl->npins; i++) { int irq = irq_create_mapping(atmel_pioctrl->irq_domain, i);
Since commit d59f6617eef0 ("genirq: Allow fwnode to carry name information only") an IRQ domain is always given a name during allocation (e.g. used for the debugfs entry). Drop the no longer valid name assignment, which would lead to an attempt to free a string constant when removing the domain on late probe failures (e.g. probe deferral). Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only") Cc: stable@vger.kernel.org # 4.13 Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/pinctrl/pinctrl-at91-pio4.c | 1 - 1 file changed, 1 deletion(-)