diff mbox series

[2/3] gpio: Add new flag BGPIOF_NO_INPUT

Message ID 20230126-gpio-mmio-fix-v1-2-8a20ce0e8275@ncr.com
State New
Headers show
Series Introduce new optional property to mark port as write only | expand

Commit Message

Niall Leonard via B4 Submission Endpoint Jan. 26, 2023, 10:17 a.m. UTC
From: Niall Leonard <nl250060@ncr.com>

Signed-off-by: Niall Leonard <nl250060@ncr.com>
---
 include/linux/gpio/driver.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Jan. 27, 2023, 12:54 p.m. UTC | #1
On Thu, Jan 26, 2023 at 11:18 AM Niall Leonard via B4 Submission
Endpoint <devnull+nl250060.ncr.com@kernel.org> wrote:

> From: Niall Leonard <nl250060@ncr.com>
>
> Signed-off-by: Niall Leonard <nl250060@ncr.com>

I would squash this with the other patch adding it to the MMIO driver
per the principle one patch = one technical step.

Anyway:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Leonard, Niall Jan. 31, 2023, 10:22 a.m. UTC | #2
On 27/01/2023 12:54, Linus Walleij wrote:
> *External Message* - Use caution before opening links or attachments
> 
> On Thu, Jan 26, 2023 at 11:18 AM Niall Leonard via B4 Submission
> Endpoint <devnull+nl250060.ncr.com@kernel.org> wrote:
> 
>> From: Niall Leonard <nl250060@ncr.com>
>>
>> Signed-off-by: Niall Leonard <nl250060@ncr.com>
> 
> I would squash this with the other patch adding it to the MMIO driver
> per the principle one patch = one technical step.
> 
> Anyway:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij
Thanks for reviewing.
I will do as you suggest in the next version.

Regards,
Niall Leonard
diff mbox series

Patch

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 44783fc16125..e8e57310e3b8 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -682,6 +682,7 @@  int bgpio_init(struct gpio_chip *gc, struct device *dev,
 #define BGPIOF_READ_OUTPUT_REG_SET	BIT(4) /* reg_set stores output value */
 #define BGPIOF_NO_OUTPUT		BIT(5) /* only input */
 #define BGPIOF_NO_SET_ON_INPUT		BIT(6)
+#define BGPIOF_NO_INPUT				BIT(7)	/* only output */
 
 int gpiochip_irq_map(struct irq_domain *d, unsigned int irq,
 		     irq_hw_number_t hwirq);