| Message ID | 20221219123208.5505-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/4] pinctrl: intel: Add default case to intel_config_set_pull() | expand |
On Mon, Dec 19, 2022 at 02:32:05PM +0200, Andy Shevchenko wrote: > For the sake of symmetry with intel_config_get_pull(), add > a default case to the outer switch. The stats for the entire series: drivers/pinctrl/intel/pinctrl-intel.c | 45 +++++++++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 18 deletions(-)
On Mon, Dec 19, 2022 at 04:41:34PM +0200, Andy Shevchenko wrote: > On Mon, Dec 19, 2022 at 02:32:05PM +0200, Andy Shevchenko wrote: > > For the sake of symmetry with intel_config_get_pull(), add > > a default case to the outer switch. > > The stats for the entire series: > > drivers/pinctrl/intel/pinctrl-intel.c | 45 +++++++++++++++++++++++++++------------------ > 1 file changed, 27 insertions(+), 18 deletions(-) Thanks! For the series, Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Tue, Dec 20, 2022 at 08:18:42AM +0200, Mika Westerberg wrote: > On Mon, Dec 19, 2022 at 04:41:34PM +0200, Andy Shevchenko wrote: > > On Mon, Dec 19, 2022 at 02:32:05PM +0200, Andy Shevchenko wrote: > > > For the sake of symmetry with intel_config_get_pull(), add > > > a default case to the outer switch. > > > > The stats for the entire series: > > > > drivers/pinctrl/intel/pinctrl-intel.c | 45 +++++++++++++++++++++++++++------------------ > > 1 file changed, 27 insertions(+), 18 deletions(-) > > Thanks! > > For the series, > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Pushed to my review and testing queue, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 8181a65fb815..4b1d5a21aa68 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -758,6 +758,10 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin, } break; + + default: + ret = -EINVAL; + break; } if (!ret)
For the sake of symmetry with intel_config_get_pull(), add a default case to the outer switch. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 4 ++++ 1 file changed, 4 insertions(+)