| Message ID | 20221017171506.64183-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] pinctrl: intel: Use str_enable_disable() helper | expand |
On Mon, Oct 17, 2022 at 7:14 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Use str_enable_disable() helper instead of open coding the same. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Oct 18, 2022 at 10:30:09AM +0200, Linus Walleij wrote: > On Mon, Oct 17, 2022 at 7:14 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > Use str_enable_disable() helper instead of open coding the same. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Pushed to my review and testing queue, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 3695d7cb1d01..e9f4f95913ab 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -15,6 +15,7 @@ #include <linux/platform_device.h> #include <linux/property.h> #include <linux/seq_file.h> +#include <linux/string_helpers.h> #include <linux/time.h> #include <linux/pinctrl/consumer.h> @@ -1171,7 +1172,7 @@ static int intel_gpio_irq_wake(struct irq_data *d, unsigned int on) else disable_irq_wake(pctrl->irq); - dev_dbg(pctrl->dev, "%sable wake for pin %u\n", on ? "en" : "dis", pin); + dev_dbg(pctrl->dev, "%s wake for pin %u\n", str_enable_disable(on), pin); return 0; }
Use str_enable_disable() helper instead of open coding the same. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)