From patchwork Tue Sep 20 13:30:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1680089 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JJc0ARY6; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4MX2V74ql2z1ypH for ; Tue, 20 Sep 2022 23:30:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiITNaU (ORCPT ); Tue, 20 Sep 2022 09:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbiITNaS (ORCPT ); Tue, 20 Sep 2022 09:30:18 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D08D330563; Tue, 20 Sep 2022 06:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663680617; x=1695216617; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Bn99q4ngGyop/53C923Ky1yeNu9zZONopt7ou69a41U=; b=JJc0ARY6k/m2Y9qdXqPJSRYHsoT2whSickylCOlpA5YhmFpcPxP8AC51 lhVQgadQlYSkKa2nt8K9mgij/4oeOXA+YJGkKcUATt2Ms/CsSnOCQvXp7 7r8Y2AJGBPrqe2/F/vkYZVfAuZZavNANAHDdziuwI+MYB+GIvtvslqltZ 7TP4/khnmYk5JXMjg0BIfIu2l8x98LlXCFCoroFMrzhppZqZZvrpl4yA7 p584urM2w9er4RnGL32aoFUjgi5mMkWR/92/zXvqpUM3mQ5PBKk1thjvL a5iNQ94TGEDwAnDaBzKtTlo4GYsw3OMxxomqxhTIoCJQpYSUe8f37ZuCK Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="299681408" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="299681408" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 06:30:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="794259561" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 20 Sep 2022 06:30:15 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DA3F9238; Tue, 20 Sep 2022 16:30:32 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bamvor Jian Zhang , Linus Walleij Subject: [PATCH v1 1/1] gpio: mockup: Fix potential resource leakage when register a chip Date: Tue, 20 Sep 2022 16:30:31 +0300 Message-Id: <20220920133031.30031-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org If creation of software node fails, the locally allocated string array is left unfreed. Free it on error path. Fixes: 6fda593f3082 ("gpio: mockup: Convert to use software nodes") Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-mockup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index a2e505a7545c..d6e42159fe44 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -533,8 +533,10 @@ static int __init gpio_mockup_register_chip(int idx) } fwnode = fwnode_create_software_node(properties, NULL); - if (IS_ERR(fwnode)) + if (IS_ERR(fwnode)) { + kfree_strarray(line_names, ngpio); return PTR_ERR(fwnode); + } pdevinfo.name = "gpio-mockup"; pdevinfo.id = idx;