| Message ID | 20220809143105.17967-2-shenwei.wang@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add IMX8 SCU GPIO support | expand |
On 09/08/2022 17:31, Shenwei Wang wrote: > Add binding document for the imx-scu gpio driver. > > Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com> > --- > .../bindings/gpio/fsl,imx8-scu-gpio.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml > new file mode 100644 > index 000000000000..4cbe3108a612 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO driver over IMX SCU firmware API > + > +maintainers: > + - Shenwei Wang <shenwei.wang@nxp.com> > + > +description: | > + This module provides the standard interface to control the > + resource pins in SCU domain on i.MX8 platforms. > + > +properties: > + compatible: > + enum: > + - fsl,imx8-scu-gpio This should be rather a specific imx8 chip. See other imx8 SCU bindings. Strictly speaking there is no "imx8" SoC and compatible should be derived from SoC. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, August 9, 2022 11:05 AM > To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev > Subject: [EXT] Re: [PATCH v2 1/3] dt-bindings: gpio: Add imx-scu gpio driver > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8-scu-gpio > > This should be rather a specific imx8 chip. See other imx8 SCU bindings. > Strictly speaking there is no "imx8" SoC and compatible should be derived from > SoC. Make sense. Thank you very much for the comments. Regards Shenwei > > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml new file mode 100644 index 000000000000..4cbe3108a612 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO driver over IMX SCU firmware API + +maintainers: + - Shenwei Wang <shenwei.wang@nxp.com> + +description: | + This module provides the standard interface to control the + resource pins in SCU domain on i.MX8 platforms. + +properties: + compatible: + enum: + - fsl,imx8-scu-gpio + + "#gpio-cells": + const: 2 + + gpio-controller: true + +required: + - compatible + - "#gpio-cells" + - gpio-controller + +additionalProperties: false + +examples: + - | + gpio0: gpio { + compatible = "fsl,imx8-scu-gpio"; + gpio-controller; + #gpio-cells = <2>; + };
Add binding document for the imx-scu gpio driver. Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com> --- .../bindings/gpio/fsl,imx8-scu-gpio.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml