| Message ID | 20220315091106.613153-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] pinctrl: qcom-pmic-gpio: Add support for pm8450 | expand |
On 15/03/2022 10:11, Dmitry Baryshkov wrote: > PM8450 provides 4 GPIOs. Add a compatible entry for this GPIO block. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes since v1: > - Added dt-bindings entry to the pinctrl/qcom,pmic-gpio.yaml This should be a separate patch. Best regards, Krzysztof
On 15/03/2022 13:33, Krzysztof Kozlowski wrote: > On 15/03/2022 10:11, Dmitry Baryshkov wrote: >> PM8450 provides 4 GPIOs. Add a compatible entry for this GPIO block. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> Changes since v1: >> - Added dt-bindings entry to the pinctrl/qcom,pmic-gpio.yaml > > This should be a separate patch. Quoting Linus Wallej: > I am fine with bindings being fixed in the same patch for this type > of oneliners. So, I added it to the same patch.
On 15/03/2022 12:06, Dmitry Baryshkov wrote: > On 15/03/2022 13:33, Krzysztof Kozlowski wrote: >> On 15/03/2022 10:11, Dmitry Baryshkov wrote: >>> PM8450 provides 4 GPIOs. Add a compatible entry for this GPIO block. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> Changes since v1: >>> - Added dt-bindings entry to the pinctrl/qcom,pmic-gpio.yaml >> >> This should be a separate patch. > > Quoting Linus Wallej: > > I am fine with bindings being fixed in the same patch for this type > > of oneliners. > > So, I added it to the same patch. ok, then: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On Tue, Mar 15, 2022 at 10:11 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > PM8450 provides 4 GPIOs. Add a compatible entry for this GPIO block. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patch applied. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml index 9400b665a46f..fe2bcf0694d9 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml @@ -36,6 +36,7 @@ properties: - qcom,pm8350-gpio - qcom,pm8350b-gpio - qcom,pm8350c-gpio + - qcom,pm8450-gpio - qcom,pm8916-gpio - qcom,pm8917-gpio - qcom,pm8921-gpio diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index f2eac3b05d67..4fbf8d3938ef 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -1164,6 +1164,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 }, { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 }, { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, + { .compatible = "qcom,pm8450-gpio", .data = (void *) 4 }, { .compatible = "qcom,pm8916-gpio", .data = (void *) 4 }, { .compatible = "qcom,pm8941-gpio", .data = (void *) 36 }, /* pm8950 has 8 GPIOs with holes on 3 */
PM8450 provides 4 GPIOs. Add a compatible entry for this GPIO block. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes since v1: - Added dt-bindings entry to the pinctrl/qcom,pmic-gpio.yaml --- Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 1 + drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + 2 files changed, 2 insertions(+)