| Message ID | 20211220121825.6446-3-tinghan.shen@mediatek.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add basic SoC support for mediatek mt8195 | expand |
On Mon, Dec 20, 2021 at 08:18:23PM +0800, Tinghan Shen wrote: > Some mtk spi nor has dedicated dma(s) inside. Add a new clock name, axi, > for spi nor dma bus clock. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Mon, Dec 20, 2021 at 08:18:23PM +0800, Tinghan Shen wrote: > Some mtk spi nor has dedicated dma(s) inside. Add a new clock name, axi, > for spi nor dma bus clock. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On 20/12/2021 13:18, Tinghan Shen wrote: > Some mtk spi nor has dedicated dma(s) inside. Add a new clock name, axi, > for spi nor dma bus clock. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml > index 7393f30535df..478afebfec9c 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml > @@ -43,14 +43,19 @@ properties: > maxItems: 1 > > clocks: > + minItems: 2 > items: > - description: clock used for spi bus > - description: clock used for controller > + - description: clock used for nor dma bus. this depends on hardware > + design, so this is optional. > > clock-names: > + minItems: 2 > items: > - const: spi > - const: sf > + - const: axi > > required: > - compatible > @@ -84,4 +89,3 @@ examples: > }; > }; > }; > - >
diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml index 7393f30535df..478afebfec9c 100644 --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml @@ -43,14 +43,19 @@ properties: maxItems: 1 clocks: + minItems: 2 items: - description: clock used for spi bus - description: clock used for controller + - description: clock used for nor dma bus. this depends on hardware + design, so this is optional. clock-names: + minItems: 2 items: - const: spi - const: sf + - const: axi required: - compatible @@ -84,4 +89,3 @@ examples: }; }; }; -
Some mtk spi nor has dedicated dma(s) inside. Add a new clock name, axi, for spi nor dma bus clock. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> --- .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)