diff mbox series

pinctrl: bcm2835: Allow building driver as a module

Message ID 20211019221127.1953001-1-f.fainelli@gmail.com
State New
Headers show
Series pinctrl: bcm2835: Allow building driver as a module | expand

Commit Message

Florian Fainelli Oct. 19, 2021, 10:11 p.m. UTC
Update the pinctrl-bcm2835 driver to support being built as as a module
by converting it to a module_platform_driver() with the appropriate
module license, authors and description.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/pinctrl/bcm/Kconfig           | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm2835.c | 9 ++++++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

Comments

nicolas saenz julienne Oct. 20, 2021, 11:35 a.m. UTC | #1
On Tue, 2021-10-19 at 15:11 -0700, Florian Fainelli wrote:
> Update the pinctrl-bcm2835 driver to support being built as as a module
> by converting it to a module_platform_driver() with the appropriate
> module license, authors and description.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>

Regards,
Nicolas
Linus Walleij Oct. 24, 2021, 10:55 p.m. UTC | #2
On Wed, Oct 20, 2021 at 12:14 AM Florian Fainelli <f.fainelli@gmail.com> wrote:

> Update the pinctrl-bcm2835 driver to support being built as as a module
> by converting it to a module_platform_driver() with the appropriate
> module license, authors and description.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Why not!
Patch applied.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index c9c5efc92731..8fc1feedd861 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -18,7 +18,7 @@  config PINCTRL_BCM281XX
 	  framework.  GPIO is provided by a separate GPIO driver.
 
 config PINCTRL_BCM2835
-	bool "Broadcom BCM2835 GPIO (with PINCONF) driver"
+	tristate "Broadcom BCM2835 GPIO (with PINCONF) driver"
 	depends on OF && (ARCH_BCM2835 || ARCH_BRCMSTB || COMPILE_TEST)
 	select PINMUX
 	select PINCONF
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 6e6fefeb21ea..2abcc6ce4eba 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -20,6 +20,7 @@ 
 #include <linux/irqdesc.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/of_address.h>
 #include <linux/of.h>
 #include <linux/of_irq.h>
@@ -1332,4 +1333,10 @@  static struct platform_driver bcm2835_pinctrl_driver = {
 		.suppress_bind_attrs = true,
 	},
 };
-builtin_platform_driver(bcm2835_pinctrl_driver);
+module_platform_driver(bcm2835_pinctrl_driver);
+
+MODULE_AUTHOR("Chris Boot");
+MODULE_AUTHOR("Simon Arlott");
+MODULE_AUTHOR("Stephen Warren");
+MODULE_DESCRIPTION("Broadcom BCM2835/2711 pinctrl and GPIO driver");
+MODULE_LICENSE("GPL");