| Message ID | 20211018005915.17601-1-luizluca@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c' | expand |
Hi Luiz, Thanks for your patch. I thought I had reviewed all of this since the kernel test robot complains once for something similar but it seems I missed this one :). On Mon, Oct 18, 2021 at 2:59 AM <luizluca@gmail.com> wrote: > > From: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > declared in ralink_regs.h. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > --- > drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/ralink/pinctrl-mt7620.c b/drivers/pinctrl/ralink/pinctrl-mt7620.c > index 425d55a2ee19..6853b5b8b0fe 100644 > --- a/drivers/pinctrl/ralink/pinctrl-mt7620.c > +++ b/drivers/pinctrl/ralink/pinctrl-mt7620.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > > +#include <asm/mach-ralink/ralink_regs.h> > #include <asm/mach-ralink/mt7620.h> > #include <linux/module.h> > #include <linux/platform_device.h> > -- > 2.33.0 > Can you please add the "Fixes" tag and CC also stable linux? With those two added, please send v2. Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") Cc: stable@vger.kernel.org Thanks, Sergio Paracuellos
On Mon, Oct 18, 2021 at 6:57 AM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > > Hi Luiz, > > Thanks for your patch. I thought I had reviewed all of this since the > kernel test robot complains once for something similar but it seems I > missed this one :). > > On Mon, Oct 18, 2021 at 2:59 AM <luizluca@gmail.com> wrote: > > > > From: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > > > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > > declared in ralink_regs.h. > > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > --- > > drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pinctrl/ralink/pinctrl-mt7620.c b/drivers/pinctrl/ralink/pinctrl-mt7620.c > > index 425d55a2ee19..6853b5b8b0fe 100644 > > --- a/drivers/pinctrl/ralink/pinctrl-mt7620.c > > +++ b/drivers/pinctrl/ralink/pinctrl-mt7620.c > > @@ -1,5 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0-only > > > > +#include <asm/mach-ralink/ralink_regs.h> > > #include <asm/mach-ralink/mt7620.h> > > #include <linux/module.h> > > #include <linux/platform_device.h> > > -- > > 2.33.0 > > > > Can you please add the "Fixes" tag and CC also stable linux? With > those two added, please send v2. > > Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config > into a new 'pinctrl-mt7620.c' file") > Cc: stable@vger.kernel.org I have already sent v2 of this patch including by myself what I was asking you to do, since no answer at all came from your side. Thanks, Sergio Paracuellos > > Thanks, > Sergio Paracuellos
diff --git a/drivers/pinctrl/ralink/pinctrl-mt7620.c b/drivers/pinctrl/ralink/pinctrl-mt7620.c index 425d55a2ee19..6853b5b8b0fe 100644 --- a/drivers/pinctrl/ralink/pinctrl-mt7620.c +++ b/drivers/pinctrl/ralink/pinctrl-mt7620.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only +#include <asm/mach-ralink/ralink_regs.h> #include <asm/mach-ralink/mt7620.h> #include <linux/module.h> #include <linux/platform_device.h>