| Message ID | 20211008122517.617633-1-fabien.dessenne@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: stm32: use valid pin identifier in stm32_pinctrl_resume() | expand |
On Fri, Oct 8, 2021 at 2:25 PM Fabien Dessenne <fabien.dessenne@foss.st.com> wrote: > When resuming from low power, the driver attempts to restore the > configuration of some pins. This is done by a call to: > stm32_pinctrl_restore_gpio_regs(struct stm32_pinctrl *pctl, u32 pin) > where 'pin' must be a valid pin value (i.e. matching some 'groups->pin'). > Fix the current implementation which uses some wrong 'pin' value. > > Fixes: e2f3cf18c3e2 ("pinctrl: stm32: add suspend/resume management") > Signed-off-by: Fabien Dessenne <fabien.dessenne@foss.st.com> Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 68b3886f9f0f..dfd8888a222a 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -1644,8 +1644,8 @@ int __maybe_unused stm32_pinctrl_resume(struct device *dev) struct stm32_pinctrl_group *g = pctl->groups; int i; - for (i = g->pin; i < g->pin + pctl->ngroups; i++) - stm32_pinctrl_restore_gpio_regs(pctl, i); + for (i = 0; i < pctl->ngroups; i++, g++) + stm32_pinctrl_restore_gpio_regs(pctl, g->pin); return 0; }
When resuming from low power, the driver attempts to restore the configuration of some pins. This is done by a call to: stm32_pinctrl_restore_gpio_regs(struct stm32_pinctrl *pctl, u32 pin) where 'pin' must be a valid pin value (i.e. matching some 'groups->pin'). Fix the current implementation which uses some wrong 'pin' value. Fixes: e2f3cf18c3e2 ("pinctrl: stm32: add suspend/resume management") Signed-off-by: Fabien Dessenne <fabien.dessenne@foss.st.com> --- drivers/pinctrl/stm32/pinctrl-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)