Message ID | 20210922074140.22178-1-biju.das.jz@bp.renesas.com |
---|---|
State | New |
Headers | show |
Series | pinctrl: renesas: rzg2l: Fix missing port register 21h | expand |
Hi Biju, On Wed, Sep 22, 2021 at 9:54 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Remove the duplicate port register 22h and replace it with missing port > register 21h. Thanks for your patch! > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue as a fix in renesas-pinctrl-for-v5.15, as this will become a dependency when enabling SDHI/SD0, right? Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 24 September 2021 09:46 > To: Biju Das <biju.das.jz@bp.renesas.com> > Cc: Linus Walleij <linus.walleij@linaro.org>; Linux-Renesas <linux- > renesas-soc@vger.kernel.org>; open list:GPIO SUBSYSTEM <linux- > gpio@vger.kernel.org>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju > Das <biju.das@bp.renesas.com>; Prabhakar Mahadev Lad <prabhakar.mahadev- > lad.rj@bp.renesas.com> > Subject: Re: [PATCH] pinctrl: renesas: rzg2l: Fix missing port register > 21h > > Hi Biju, > > On Wed, Sep 22, 2021 at 9:54 AM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Remove the duplicate port register 22h and replace it with missing > > port register 21h. > > Thanks for your patch! > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue > as a fix in renesas-pinctrl-for-v5.15, as this will become a dependency > when enabling SDHI/SD0, right? OK thanks. port register P21 corresponds to p17_0, p17_1 and p17_2. Regards, Biju > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
Hi Biju, On Fri, Sep 24, 2021 at 11:03 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > -----Original Message----- > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > Sent: 24 September 2021 09:46 > > To: Biju Das <biju.das.jz@bp.renesas.com> > > Cc: Linus Walleij <linus.walleij@linaro.org>; Linux-Renesas <linux- > > renesas-soc@vger.kernel.org>; open list:GPIO SUBSYSTEM <linux- > > gpio@vger.kernel.org>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju > > Das <biju.das@bp.renesas.com>; Prabhakar Mahadev Lad <prabhakar.mahadev- > > lad.rj@bp.renesas.com> > > Subject: Re: [PATCH] pinctrl: renesas: rzg2l: Fix missing port register > > 21h > > > > On Wed, Sep 22, 2021 at 9:54 AM Biju Das <biju.das.jz@bp.renesas.com> > > wrote: > > > Remove the duplicate port register 22h and replace it with missing > > > port register 21h. > > > > Thanks for your patch! > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue > > as a fix in renesas-pinctrl-for-v5.15, as this will become a dependency > > when enabling SDHI/SD0, right? > > OK thanks. port register P21 corresponds to p17_0, p17_1 and p17_2. Oh, this bug only affects P17_[012], not P18_[01] (which is used for I2C on the SOM, not SD0, my mistake)? As P17_[012] are not connected on the SOM, I'll postpone this to v5.16, unless someone sees a good reason for not doing so. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index dbf2f521bb27..20b2af889ca9 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -852,7 +852,7 @@ static const u32 rzg2l_gpio_configs[] = { RZG2L_GPIO_PORT_PACK(2, 0x1e, RZG2L_MPXED_PIN_FUNCS), RZG2L_GPIO_PORT_PACK(2, 0x1f, RZG2L_MPXED_PIN_FUNCS), RZG2L_GPIO_PORT_PACK(2, 0x20, RZG2L_MPXED_PIN_FUNCS), - RZG2L_GPIO_PORT_PACK(3, 0x22, RZG2L_MPXED_PIN_FUNCS), + RZG2L_GPIO_PORT_PACK(3, 0x21, RZG2L_MPXED_PIN_FUNCS), RZG2L_GPIO_PORT_PACK(2, 0x22, RZG2L_MPXED_PIN_FUNCS), RZG2L_GPIO_PORT_PACK(2, 0x23, RZG2L_MPXED_PIN_FUNCS), RZG2L_GPIO_PORT_PACK(3, 0x24, RZG2L_MPXED_ETH_PIN_FUNCS(PIN_CFG_IOLH_ETH0)),
Remove the duplicate port register 22h and replace it with missing port register 21h. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)