From patchwork Thu Mar 4 19:48:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Marek X-Patchwork-Id: 1447474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=marek-ca.20150623.gappssmtp.com header.i=@marek-ca.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=LgJjks1g; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Ds1hh42C2z9sW8 for ; Fri, 5 Mar 2021 06:51:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233328AbhCDTuo (ORCPT ); Thu, 4 Mar 2021 14:50:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231941AbhCDTuS (ORCPT ); Thu, 4 Mar 2021 14:50:18 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FEDAC061756 for ; Thu, 4 Mar 2021 11:49:38 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id l4so14340218qkl.0 for ; Thu, 04 Mar 2021 11:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GGdJz+F7X0YEt83RQ+ubusZIDW1JVh1grqyHtT5UzMM=; b=LgJjks1gY6hesLWCBLbeQ72UJ/bbmO2sufio87kHG+xYrjFTzqgXsEkS7aa9nU58ee 5LEMGPvWEdLezDaalptz3EG6Pz3H8KLvb0GXxspiYlH5Swi0D6EPQj+uBc3MNd3DgyHX xhM95emL2cvGV5tTlBK+tMUYiJUwuMjla2ooSmZ6hW/IGOlMbk7qH9twVgYcsIkb4Gq+ x7uWN3LbmrLxJg9HVf2LiV4WaxUZUTtP5jA/Bfm4TIzuC+oZrJZce+Sm/UhK8rvpYGM8 9Ut3jXX6bdtuWHfjpKcVD3obWhPfEt0WD81cVJdUPeAke0bTzEYO7wz9GN/2DOwljJll HuLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GGdJz+F7X0YEt83RQ+ubusZIDW1JVh1grqyHtT5UzMM=; b=LFp7RNDO/ycB6R94Q2uYYjr+UJzSnBr7/QBrUpgyxmnppB0WlgLEthscm40GAIq9A9 R5c1DlLXJ0R9WcxNqacPMkMMcuADkG38uc+22s26bQ25od/xZ5d0kPK2gBW7nBxgRs42 SEOrZLZtNf/MS16ZXd0676690/3mNMoBoxRQdpABVTLd7Ysf7piKcHVV2wJadpCBEpcK y9f1vQ8ThwPMazGkd2SjuBW3aK+/+xs5ITwP9f/UiJuX11DDkvShqpYXDYbw3tru8VG3 qtPP+jkhbX6ZuM14UDJ1ixSHlRS6fat2fcvZtKVizefnkmkpHbtYAZfwpSgXQkqpkTrp 1mvQ== X-Gm-Message-State: AOAM533XxJScWyO5nc4z3qghaERmWEvxLkhWe9/5AXhp03523ljFGsIa 3SH7Fc9oZA1SF8XGXEuWJoBL/A== X-Google-Smtp-Source: ABdhPJwXKuTqgQfGdVQj9GpZbfdRvSCkYzjEAzQEqWN+UBGguJj8YzoO+VZRqRPOfUA4GqwKo7FhVQ== X-Received: by 2002:a37:6397:: with SMTP id x145mr5479020qkb.358.1614887377405; Thu, 04 Mar 2021 11:49:37 -0800 (PST) Received: from localhost.localdomain (modemcable068.184-131-66.mc.videotron.ca. [66.131.184.68]) by smtp.gmail.com with ESMTPSA id c22sm392908qtn.74.2021.03.04.11.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 11:49:36 -0800 (PST) From: Jonathan Marek To: linux-arm-msm@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Linus Walleij , Srinivas Kandagatla , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values Date: Thu, 4 Mar 2021 14:48:16 -0500 Message-Id: <20210304194816.3843-1-jonathan@marek.ca> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org If these fields are not set in dts, the driver will use these variables uninitialized to set the fields. Not only will it set garbage values for these fields, but it can overflow into other fields and break those. In the current sm8250 dts, the dmic01 entries do not have a pullup setting, and might not work without this change. Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver") Signed-off-by: Jonathan Marek Reported-by: kernel test robot Reported-by: Dan Carpenter Reviewed-by: Bjorn Andersson Reviewed-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c index 369ee20a7ea95..2f19ab4db7208 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -392,7 +392,7 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, unsigned long *configs, unsigned int nconfs) { struct lpi_pinctrl *pctrl = dev_get_drvdata(pctldev->dev); - unsigned int param, arg, pullup, strength; + unsigned int param, arg, pullup = LPI_GPIO_BIAS_DISABLE, strength = 2; bool value, output_enabled = false; const struct lpi_pingroup *g; unsigned long sval;