| Message ID | 20210219223910.1831-1-luca@lucaceresoli.net |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] mfd: lp87565: fix typo in define names | expand |
On Fri, 19 Feb 2021, Luca Ceresoli wrote: > "GOIO" should be "GPIO" here. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > drivers/gpio/gpio-lp87565.c | 6 +++--- > include/linux/mfd/lp87565.h | 28 ++++++++++++++-------------- > 2 files changed, 17 insertions(+), 17 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
On Fri, Feb 19, 2021 at 11:39 PM Luca Ceresoli <luca@lucaceresoli.net> wrote: > > "GOIO" should be "GPIO" here. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- For GPIO part: Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Hi, On 08/03/21 15:04, Lee Jones wrote: > On Fri, 19 Feb 2021, Luca Ceresoli wrote: > >> "GOIO" should be "GPIO" here. >> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >> --- >> drivers/gpio/gpio-lp87565.c | 6 +++--- >> include/linux/mfd/lp87565.h | 28 ++++++++++++++-------------- >> 2 files changed, 17 insertions(+), 17 deletions(-) > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> Gentle ping on patches 1 and 3. Both have at least an ack and are fairly trivial. Both apply cleanly on current master. Thanks.
On Wed, 12 May 2021, Luca Ceresoli wrote: > Hi, > > On 08/03/21 15:04, Lee Jones wrote: > > On Fri, 19 Feb 2021, Luca Ceresoli wrote: > > > >> "GOIO" should be "GPIO" here. > >> > >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > >> --- > >> drivers/gpio/gpio-lp87565.c | 6 +++--- > >> include/linux/mfd/lp87565.h | 28 ++++++++++++++-------------- > >> 2 files changed, 17 insertions(+), 17 deletions(-) > > > > For my own reference (apply this as-is to your sign-off block): > > > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > > Gentle ping on patches 1 and 3. Both have at least an ack and are fairly > trivial. Both apply cleanly on current master. I'll take care of these this time, but in future, if you don't receive further responses for ~2 weeks, you should collect all of the Acks and submit a [RESEND].
On Mon, 08 Mar 2021, Bartosz Golaszewski wrote: > On Fri, Feb 19, 2021 at 11:39 PM Luca Ceresoli <luca@lucaceresoli.net> wrote: > > > > "GOIO" should be "GPIO" here. > > > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > > --- > > For GPIO part: > > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Do you require a pull-request from an immutable branch? Or can I just take these as-is?
Hi Lee, On 12/05/21 11:59, Lee Jones wrote: > On Wed, 12 May 2021, Luca Ceresoli wrote: > >> Hi, >> >> On 08/03/21 15:04, Lee Jones wrote: >>> On Fri, 19 Feb 2021, Luca Ceresoli wrote: >>> >>>> "GOIO" should be "GPIO" here. >>>> >>>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >>>> --- >>>> drivers/gpio/gpio-lp87565.c | 6 +++--- >>>> include/linux/mfd/lp87565.h | 28 ++++++++++++++-------------- >>>> 2 files changed, 17 insertions(+), 17 deletions(-) >>> >>> For my own reference (apply this as-is to your sign-off block): >>> >>> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> >> >> Gentle ping on patches 1 and 3. Both have at least an ack and are fairly >> trivial. Both apply cleanly on current master. > > I'll take care of these this time, but in future, if you don't receive > further responses for ~2 weeks, you should collect all of the Acks and > submit a [RESEND]. Apologies, I'll try to remember next time. Thanks for taking care of them.
diff --git a/drivers/gpio/gpio-lp87565.c b/drivers/gpio/gpio-lp87565.c index e1244520cf7d..fcde6708b5df 100644 --- a/drivers/gpio/gpio-lp87565.c +++ b/drivers/gpio/gpio-lp87565.c @@ -123,14 +123,14 @@ static int lp87565_gpio_set_config(struct gpio_chip *gc, unsigned int offset, return regmap_update_bits(gpio->map, LP87565_REG_GPIO_CONFIG, BIT(offset + - __ffs(LP87565_GOIO1_OD)), + __ffs(LP87565_GPIO1_OD)), BIT(offset + - __ffs(LP87565_GOIO1_OD))); + __ffs(LP87565_GPIO1_OD))); case PIN_CONFIG_DRIVE_PUSH_PULL: return regmap_update_bits(gpio->map, LP87565_REG_GPIO_CONFIG, BIT(offset + - __ffs(LP87565_GOIO1_OD)), 0); + __ffs(LP87565_GPIO1_OD)), 0); default: return -ENOTSUPP; } diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h index d44ddfb6bb63..2620554f357a 100644 --- a/include/linux/mfd/lp87565.h +++ b/include/linux/mfd/lp87565.h @@ -222,20 +222,20 @@ enum lp87565_device_type { #define LP87565_GPIO2_SEL BIT(1) #define LP87565_GPIO1_SEL BIT(0) -#define LP87565_GOIO3_OD BIT(6) -#define LP87565_GOIO2_OD BIT(5) -#define LP87565_GOIO1_OD BIT(4) -#define LP87565_GOIO3_DIR BIT(2) -#define LP87565_GOIO2_DIR BIT(1) -#define LP87565_GOIO1_DIR BIT(0) - -#define LP87565_GOIO3_IN BIT(2) -#define LP87565_GOIO2_IN BIT(1) -#define LP87565_GOIO1_IN BIT(0) - -#define LP87565_GOIO3_OUT BIT(2) -#define LP87565_GOIO2_OUT BIT(1) -#define LP87565_GOIO1_OUT BIT(0) +#define LP87565_GPIO3_OD BIT(6) +#define LP87565_GPIO2_OD BIT(5) +#define LP87565_GPIO1_OD BIT(4) +#define LP87565_GPIO3_DIR BIT(2) +#define LP87565_GPIO2_DIR BIT(1) +#define LP87565_GPIO1_DIR BIT(0) + +#define LP87565_GPIO3_IN BIT(2) +#define LP87565_GPIO2_IN BIT(1) +#define LP87565_GPIO1_IN BIT(0) + +#define LP87565_GPIO3_OUT BIT(2) +#define LP87565_GPIO2_OUT BIT(1) +#define LP87565_GPIO1_OUT BIT(0) /* Number of step-down converters available */ #define LP87565_NUM_BUCK 6
"GOIO" should be "GPIO" here. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- drivers/gpio/gpio-lp87565.c | 6 +++--- include/linux/mfd/lp87565.h | 28 ++++++++++++++-------------- 2 files changed, 17 insertions(+), 17 deletions(-)