| Message ID | 20210125203542.51513-1-drew@beagleboard.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] pinctrl: single: set function name when adding function | expand |
* Drew Fustini <drew@beagleboard.org> [210125 20:36]: > pcs_add_function() fails to set the function name in struct pcs_function > when adding a new function. As a result this line in pcs_set_mux(): > > dev_dbg(pcs->dev, "enabling %s function%i\n", > func->name, fselector); > > prints "(null)" for the function: > > pinctrl-single 44e10800.pinmux: enabling (null) function0 > pinctrl-single 44e10800.pinmux: enabling (null) function1 > pinctrl-single 44e10800.pinmux: enabling (null) function2 > pinctrl-single 44e10800.pinmux: enabling (null) function3 > > With this fix, the output is now: > > pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0 > pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1 > pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2 > pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3 Acked-by: Tony Lindgren <tony@atomide.com>
On Mon, Jan 25, 2021 at 9:36 PM Drew Fustini <drew@beagleboard.org> wrote: > pcs_add_function() fails to set the function name in struct pcs_function > when adding a new function. As a result this line in pcs_set_mux(): > > dev_dbg(pcs->dev, "enabling %s function%i\n", > func->name, fselector); > > prints "(null)" for the function: > > pinctrl-single 44e10800.pinmux: enabling (null) function0 > pinctrl-single 44e10800.pinmux: enabling (null) function1 > pinctrl-single 44e10800.pinmux: enabling (null) function2 > pinctrl-single 44e10800.pinmux: enabling (null) function3 > > With this fix, the output is now: > > pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0 > pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1 > pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2 > pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3 > > Cc: Jason Kridner <jkridner@beagleboard.org> > Cc: Robert Nelson <robertcnelson@beagleboard.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Tony Lindgren <tony@atomide.com> > Signed-off-by: Drew Fustini <drew@beagleboard.org> > --- > v2 change: > - correctly base on mainline, sorry for the noise in v1 Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index f3cd7e296712..7771316dfffa 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -777,6 +777,7 @@ static int pcs_add_function(struct pcs_device *pcs, function->vals = vals; function->nvals = nvals; + function->name = name; selector = pinmux_generic_add_function(pcs->pctl, name, pgnames, npgnames,
pcs_add_function() fails to set the function name in struct pcs_function when adding a new function. As a result this line in pcs_set_mux(): dev_dbg(pcs->dev, "enabling %s function%i\n", func->name, fselector); prints "(null)" for the function: pinctrl-single 44e10800.pinmux: enabling (null) function0 pinctrl-single 44e10800.pinmux: enabling (null) function1 pinctrl-single 44e10800.pinmux: enabling (null) function2 pinctrl-single 44e10800.pinmux: enabling (null) function3 With this fix, the output is now: pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0 pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1 pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2 pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3 Cc: Jason Kridner <jkridner@beagleboard.org> Cc: Robert Nelson <robertcnelson@beagleboard.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Drew Fustini <drew@beagleboard.org> --- v2 change: - correctly base on mainline, sorry for the noise in v1 drivers/pinctrl/pinctrl-single.c | 1 + 1 file changed, 1 insertion(+)