diff mbox series

pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one

Message ID 20201229204710.1129033-1-natechancellor@gmail.com
State New
Headers show
Series pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one | expand

Commit Message

Nathan Chancellor Dec. 29, 2020, 8:47 p.m. UTC
Clang warns:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused
variable 'wake' [-Wunused-variable]
                bool wake;
                     ^
1 warning generated.

There were two wake declarations added to nmk_gpio_dbg_show_one when
converting it to use irq_has_action but only one is used within its
scope. Remove the unused one so there is no more warning.

Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
 1 file changed, 1 deletion(-)


base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e

Comments

Linus Walleij Jan. 5, 2021, 3:15 p.m. UTC | #1
On Tue, Dec 29, 2020 at 9:47 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:

> drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused
> variable 'wake' [-Wunused-variable]
>                 bool wake;
>                      ^
> 1 warning generated.
>
> There were two wake declarations added to nmk_gpio_dbg_show_one when
> converting it to use irq_has_action but only one is used within its
> scope. Remove the unused one so there is no more warning.
>
> Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Patch applied.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index d4ea10803fd9..abfe11c7b49f 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -949,7 +949,6 @@  static void nmk_gpio_dbg_show_one(struct seq_file *s,
 	} else {
 		int irq = chip->to_irq(chip, offset);
 		const int pullidx = pull ? 1 : 0;
-		bool wake;
 		int val;
 		static const char * const pulls[] = {
 			"none        ",