| Message ID | 20201107081420.60325-22-damien.lemoal@wdc.com |
|---|---|
| State | New |
| Headers | show |
| Series | RISC-V Kendryte K210 support improvments | expand |
On 11/7/20 3:14 AM, Damien Le Moal wrote: > Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include > "Kendryte" and "canaan" as a vendor prefix for "Canaan Inc." > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 2735be1a8470..f53d4d8e7f2a 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -179,6 +179,8 @@ patternProperties: > description: CALAO Systems SAS > "^calxeda,.*": > description: Calxeda > + "^canaan,.*": > + description: Canaan, Inc. > "^caninos,.*": > description: Caninos Loucos Program > "^capella,.*": > @@ -537,6 +539,8 @@ patternProperties: > description: Ka-Ro electronics GmbH > "^keithkoep,.*": > description: Keith & Koep GmbH > + "^kendryte,.*": > + description: Canaan, Inc. > "^keymile,.*": > description: Keymile GmbH > "^khadas,.*": > So AFAIK Canaan is the company, and Kendryte is the brand. However, I was unaware of this when I did my initial porting work. So all the compatible strings like "kendryte,k210-foo" should really be "canaan,kendryte-k210-foo". These _should_ all get fixed in the device tree, but no one has done it yet. --Sean
On Sat, Nov 07, 2020 at 05:14:09PM +0900, Damien Le Moal wrote: > Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include > "Kendryte" and "canaan" as a vendor prefix for "Canaan Inc." > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 2735be1a8470..f53d4d8e7f2a 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -179,6 +179,8 @@ patternProperties: > description: CALAO Systems SAS > "^calxeda,.*": > description: Calxeda > + "^canaan,.*": > + description: Canaan, Inc. > "^caninos,.*": > description: Caninos Loucos Program > "^capella,.*": > @@ -537,6 +539,8 @@ patternProperties: > description: Ka-Ro electronics GmbH > "^keithkoep,.*": > description: Keith & Koep GmbH > + "^kendryte,.*": AFAICT, this is a marketing name for a series of SoCs? That's not a vendor. > + description: Canaan, Inc. > "^keymile,.*": > description: Keymile GmbH > "^khadas,.*": > -- > 2.28.0 >
On 2020/11/10 7:01, Rob Herring wrote: > On Sat, Nov 07, 2020 at 05:14:09PM +0900, Damien Le Moal wrote: >> Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include >> "Kendryte" and "canaan" as a vendor prefix for "Canaan Inc." >> >> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> >> --- >> Documentation/devicetree/bindings/vendor-prefixes.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml >> index 2735be1a8470..f53d4d8e7f2a 100644 >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml >> @@ -179,6 +179,8 @@ patternProperties: >> description: CALAO Systems SAS >> "^calxeda,.*": >> description: Calxeda >> + "^canaan,.*": >> + description: Canaan, Inc. >> "^caninos,.*": >> description: Caninos Loucos Program >> "^capella,.*": >> @@ -537,6 +539,8 @@ patternProperties: >> description: Ka-Ro electronics GmbH >> "^keithkoep,.*": >> description: Keith & Koep GmbH >> + "^kendryte,.*": > > AFAICT, this is a marketing name for a series of SoCs? That's not a > vendor. Correct. Sean pointed this out to me already. The vendor is "Canaan". I will change in V2 all compatible strings to have the proper format starting with the vendor, e.g. "canaan,kendryte-k210-..." or may be more simply "canaan, k210-...". > >> + description: Canaan, Inc. >> "^keymile,.*": >> description: Keymile GmbH >> "^khadas,.*": >> -- >> 2.28.0 >> >
On Sat, 2020-11-07 at 09:03 -0500, Sean Anderson wrote: > On 11/7/20 3:14 AM, Damien Le Moal wrote: > > Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include > > "Kendryte" and "canaan" as a vendor prefix for "Canaan Inc." > > > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > > --- > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 2735be1a8470..f53d4d8e7f2a 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -179,6 +179,8 @@ patternProperties: > > description: CALAO Systems SAS > > "^calxeda,.*": > > description: Calxeda > > + "^canaan,.*": > > + description: Canaan, Inc. > > "^caninos,.*": > > description: Caninos Loucos Program > > "^capella,.*": > > @@ -537,6 +539,8 @@ patternProperties: > > description: Ka-Ro electronics GmbH > > "^keithkoep,.*": > > description: Keith & Koep GmbH > > + "^kendryte,.*": > > + description: Canaan, Inc. > > "^keymile,.*": > > description: Keymile GmbH > > "^khadas,.*": > > > > So AFAIK Canaan is the company, and Kendryte is the brand. However, I > was unaware of this when I did my initial porting work. So all the > compatible strings like "kendryte,k210-foo" should really be > "canaan,kendryte-k210-foo". These _should_ all get fixed in the device > tree, but no one has done it yet. I fixed everything using "canaan,k210-foo", a little shorter than "canaan,kendryte-k210-foo" (The "k" in k210 already probably standing for Kendryte...). But I can use the longer version too. Will I was at it, I also changed directory names and config option names to also use canaan/CANAAN instead of kendryte/KENDRYTE. > > --Sean
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 2735be1a8470..f53d4d8e7f2a 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -179,6 +179,8 @@ patternProperties: description: CALAO Systems SAS "^calxeda,.*": description: Calxeda + "^canaan,.*": + description: Canaan, Inc. "^caninos,.*": description: Caninos Loucos Program "^capella,.*": @@ -537,6 +539,8 @@ patternProperties: description: Ka-Ro electronics GmbH "^keithkoep,.*": description: Keith & Koep GmbH + "^kendryte,.*": + description: Canaan, Inc. "^keymile,.*": description: Keymile GmbH "^khadas,.*":
Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include "Kendryte" and "canaan" as a vendor prefix for "Canaan Inc." Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 4 ++++ 1 file changed, 4 insertions(+)