| Message ID | 20201104160344.4929-3-coiby.xu@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] pinctrl: amd: fix incorrect way to disable debounce filter | expand |
On Wed, Nov 4, 2020 at 6:04 PM Coiby Xu <coiby.xu@gmail.com> wrote: > > RTC is 32.768kHz thus 512 RtcClk equals to 15625 usec. equals 15625 > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> One of them is enough. > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Message-ID: <2f4706a1-502f-75f0-9596-cc25b4933b6c@redhat.com> > Message-ID: <CAHp75VdYhe4YEAzULMNkhihTQwHAP3fC2F6iD=datqzyzd=4fQ@mail.gmail.com> Link: https://lore.kernel.org/... And I guess one link to a head of discussion is enough.
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index d6b2b4bd337c..4aea3e05e8c6 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -156,7 +156,7 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset, pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF); pin_reg &= ~BIT(DB_TMR_LARGE_OFF); } else if (debounce < 250000) { - time = debounce / 15600; + time = debounce / 15625; pin_reg |= time & DB_TMR_OUT_MASK; pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF); pin_reg |= BIT(DB_TMR_LARGE_OFF);
RTC is 32.768kHz thus 512 RtcClk equals to 15625 usec. Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Suggested-by: Hans de Goede <hdegoede@redhat.com> Message-ID: <2f4706a1-502f-75f0-9596-cc25b4933b6c@redhat.com> Message-ID: <CAHp75VdYhe4YEAzULMNkhihTQwHAP3fC2F6iD=datqzyzd=4fQ@mail.gmail.com> Signed-off-by: Coiby Xu <coiby.xu@gmail.com> --- drivers/pinctrl/pinctrl-amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)