| Message ID | 20201104152455.40627-2-quarium@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: pcie-idio-24: Fix IRQ handling | expand |
On Wed, Nov 04, 2020 at 04:24:53PM +0100, Arnaud de Turckheim wrote: > Fix the bitwise operation to remove only the corresponding bit from the > mask. > > Fixes: 585562046628 ("gpio: Add GPIO support for the ACCES PCIe-IDIO-24 family") > Signed-off-by: Arnaud de Turckheim <quarium@gmail.com> Reviewed-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > drivers/gpio/gpio-pcie-idio-24.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c > index a68941d19ac6..5ea517416366 100644 > --- a/drivers/gpio/gpio-pcie-idio-24.c > +++ b/drivers/gpio/gpio-pcie-idio-24.c > @@ -339,7 +339,7 @@ static void idio_24_irq_mask(struct irq_data *data) > > raw_spin_lock_irqsave(&idio24gpio->lock, flags); > > - idio24gpio->irq_mask &= BIT(bit_offset); > + idio24gpio->irq_mask &= ~BIT(bit_offset); > new_irq_mask = idio24gpio->irq_mask >> bank_offset; > > if (!new_irq_mask) { > -- > 2.25.1 >
diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c index a68941d19ac6..5ea517416366 100644 --- a/drivers/gpio/gpio-pcie-idio-24.c +++ b/drivers/gpio/gpio-pcie-idio-24.c @@ -339,7 +339,7 @@ static void idio_24_irq_mask(struct irq_data *data) raw_spin_lock_irqsave(&idio24gpio->lock, flags); - idio24gpio->irq_mask &= BIT(bit_offset); + idio24gpio->irq_mask &= ~BIT(bit_offset); new_irq_mask = idio24gpio->irq_mask >> bank_offset; if (!new_irq_mask) {
Fix the bitwise operation to remove only the corresponding bit from the mask. Fixes: 585562046628 ("gpio: Add GPIO support for the ACCES PCIe-IDIO-24 family") Signed-off-by: Arnaud de Turckheim <quarium@gmail.com> --- drivers/gpio/gpio-pcie-idio-24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)