diff mbox series

[v2,1/2] dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C

Message ID 20200930092053.2114-1-mike.looijmans@topic.nl
State New
Headers show
Series [v2,1/2] dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C | expand

Commit Message

Mike Looijmans Sept. 30, 2020, 9:20 a.m. UTC
The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
with 8 GPIOs, latched interrupts and some advanced configuration
options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
v2: Split devicetree and code into separate patches

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Bartosz Golaszewski Sept. 30, 2020, 9:40 a.m. UTC | #1
On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
>
> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> with 8 GPIOs, latched interrupts and some advanced configuration
> options. The "C" version only differs in I2C address.
>
> This adds the entry to the devicetree bindings.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> v2: Split devicetree and code into separate patches
>
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> index 3126c3817e2a..99dc1936f633 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> @@ -20,6 +20,7 @@ Required properties:
>         nxp,pcal6416
>         nxp,pcal6524
>         nxp,pcal9535
> +       nxp,pcal9554b
>         nxp,pcal9555a
>         maxim,max7310
>         maxim,max7312
> --
> 2.17.1
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Linus Walleij Sept. 30, 2020, 9:50 a.m. UTC | #2
On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:

> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> with 8 GPIOs, latched interrupts and some advanced configuration
> options. The "C" version only differs in I2C address.
>
> This adds the entry to the devicetree bindings.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> v2: Split devicetree and code into separate patches

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

This patch 1/2 does not apply to my tree, I suppose Rob has
to apply it?

I will try to apply 2/2.

Yours,
Linus Walleij
Mike Looijmans Sept. 30, 2020, 10:07 a.m. UTC | #3
Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topicproducts.com

Please consider the environment before printing this e-mail
On 30-09-2020 11:50, Linus Walleij wrote:
> On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
>
>> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
>> with 8 GPIOs, latched interrupts and some advanced configuration
>> options. The "C" version only differs in I2C address.
>>
>> This adds the entry to the devicetree bindings.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>> v2: Split devicetree and code into separate patches
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> This patch 1/2 does not apply to my tree, I suppose Rob has
> to apply it?
>
> I will try to apply 2/2.
>
> Yours,
> Linus Walleij
I based the patches on the current master. Well, master a few days ago. 
A rebase on current master also had no complaints.
Rob Herring Oct. 6, 2020, 7:32 p.m. UTC | #4
On Wed, Sep 30, 2020 at 11:50:38AM +0200, Linus Walleij wrote:
> On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
> 
> > The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> > with 8 GPIOs, latched interrupts and some advanced configuration
> > options. The "C" version only differs in I2C address.
> >
> > This adds the entry to the devicetree bindings.
> >
> > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> > ---
> > v2: Split devicetree and code into separate patches
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> This patch 1/2 does not apply to my tree, I suppose Rob has
> to apply it?

Nope, no changes in my tree.

Rob
Rob Herring Oct. 6, 2020, 7:32 p.m. UTC | #5
On Wed, 30 Sep 2020 11:20:52 +0200, Mike Looijmans wrote:
> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> with 8 GPIOs, latched interrupts and some advanced configuration
> options. The "C" version only differs in I2C address.
> 
> This adds the entry to the devicetree bindings.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> v2: Split devicetree and code into separate patches
> 
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Linus Walleij Oct. 7, 2020, 9:58 a.m. UTC | #6
On Tue, Oct 6, 2020 at 9:32 PM Rob Herring <robh@kernel.org> wrote:
> On Wed, Sep 30, 2020 at 11:50:38AM +0200, Linus Walleij wrote:
> > On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
> >
> > > The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> > > with 8 GPIOs, latched interrupts and some advanced configuration
> > > options. The "C" version only differs in I2C address.
> > >
> > > This adds the entry to the devicetree bindings.
> > >
> > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> > > ---
> > > v2: Split devicetree and code into separate patches
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > This patch 1/2 does not apply to my tree, I suppose Rob has
> > to apply it?
>
> Nope, no changes in my tree.

Weird, OK Mike apply this wherever it should be applied or rebase
on my GPIO tree and resend if you want me to apply it.

Yours,
Linus Walleij
Mike Looijmans Oct. 8, 2020, 7:36 a.m. UTC | #7
Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topicproducts.com

Please consider the environment before printing this e-mail
On 07-10-2020 11:58, Linus Walleij wrote:
> On Tue, Oct 6, 2020 at 9:32 PM Rob Herring <robh@kernel.org> wrote:
>> On Wed, Sep 30, 2020 at 11:50:38AM +0200, Linus Walleij wrote:
>>> On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
>>>
>>>> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
>>>> with 8 GPIOs, latched interrupts and some advanced configuration
>>>> options. The "C" version only differs in I2C address.
>>>>
>>>> This adds the entry to the devicetree bindings.
>>>>
>>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>>> ---
>>>> v2: Split devicetree and code into separate patches
>>>
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> This patch 1/2 does not apply to my tree, I suppose Rob has
>>> to apply it?
>>
>> Nope, no changes in my tree.
> 
> Weird, OK Mike apply this wherever it should be applied or rebase
> on my GPIO tree and resend if you want me to apply it.
> 

Could you provide me a git URL + branch to rebase it on, i'll send you a new 
patch then.
Linus Walleij Oct. 8, 2020, 12:52 p.m. UTC | #8
On Thu, Oct 8, 2020 at 9:36 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
> On 07-10-2020 11:58, Linus Walleij wrote:
> > On Tue, Oct 6, 2020 at 9:32 PM Rob Herring <robh@kernel.org> wrote:
> >> On Wed, Sep 30, 2020 at 11:50:38AM +0200, Linus Walleij wrote:
> >>> On Wed, Sep 30, 2020 at 11:21 AM Mike Looijmans <mike.looijmans@topic.nl> wrote:
> >>>
> >>>> The NXP PCAL9554B is a variant of the PCA953x GPIO expander,
> >>>> with 8 GPIOs, latched interrupts and some advanced configuration
> >>>> options. The "C" version only differs in I2C address.
> >>>>
> >>>> This adds the entry to the devicetree bindings.
> >>>>
> >>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> >>>> ---
> >>>> v2: Split devicetree and code into separate patches
> >>>
> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >>>
> >>> This patch 1/2 does not apply to my tree, I suppose Rob has
> >>> to apply it?
> >>
> >> Nope, no changes in my tree.
> >
> > Weird, OK Mike apply this wherever it should be applied or rebase
> > on my GPIO tree and resend if you want me to apply it.
> >
>
> Could you provide me a git URL + branch to rebase it on, i'll send you a new
> patch then.

It's this:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel

git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git devel

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
index 3126c3817e2a..99dc1936f633 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
@@ -20,6 +20,7 @@  Required properties:
 	nxp,pcal6416
 	nxp,pcal6524
 	nxp,pcal9535
+	nxp,pcal9554b
 	nxp,pcal9555a
 	maxim,max7310
 	maxim,max7312