| Message ID | 20200616015024.287683-1-hengqing.hu@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: amd: fix npins for uart0 in kerncz_groups | expand |
On Tue, Jun 16, 2020 at 3:50 AM Jacky Hu <hengqing.hu@gmail.com> wrote: > uart0_pins is defined as: > static const unsigned uart0_pins[] = {135, 136, 137, 138, 139}; > > which npins is wronly specified as 9 later > { > .name = "uart0", > .pins = uart0_pins, > .npins = 9, > }, > > npins should be 5 instead of 9 according to the definition. > > Signed-off-by: Jacky Hu <hengqing.hu@gmail.com> Seems like an obvious bug so patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-amd.h b/drivers/pinctrl/pinctrl-amd.h index 3e5760f1a715..d4a192df5fab 100644 --- a/drivers/pinctrl/pinctrl-amd.h +++ b/drivers/pinctrl/pinctrl-amd.h @@ -252,7 +252,7 @@ static const struct amd_pingroup kerncz_groups[] = { { .name = "uart0", .pins = uart0_pins, - .npins = 9, + .npins = 5, }, { .name = "uart1",
uart0_pins is defined as: static const unsigned uart0_pins[] = {135, 136, 137, 138, 139}; which npins is wronly specified as 9 later { .name = "uart0", .pins = uart0_pins, .npins = 9, }, npins should be 5 instead of 9 according to the definition. Signed-off-by: Jacky Hu <hengqing.hu@gmail.com> --- drivers/pinctrl/pinctrl-amd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)