| Message ID | 20200604174935.26560-1-vidyas@nvidia.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pinctrl: tegra: Use noirq suspend/resume callbacks | expand |
04.06.2020 20:49, Vidya Sagar пишет: > Use noirq suspend/resume callbacks as other drivers which implement > noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to > configure the signals used by their respective devices in the noirq phase. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c > index 21661f6490d6..195cfe557511 100644 > --- a/drivers/pinctrl/tegra/pinctrl-tegra.c > +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c > @@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev) > } > > const struct dev_pm_ops tegra_pinctrl_pm = { > - .suspend = &tegra_pinctrl_suspend, > - .resume = &tegra_pinctrl_resume > + .suspend_noirq = &tegra_pinctrl_suspend, > + .resume_noirq = &tegra_pinctrl_resume > }; > > static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx) > That's a good catch! Perhaps I2C on later Tegra SoCs also should suffer similarly to the PCIe. Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
On Thu, Jun 4, 2020 at 7:49 PM Vidya Sagar <vidyas@nvidia.com> wrote: > Use noirq suspend/resume callbacks as other drivers which implement > noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to > configure the signals used by their respective devices in the noirq phase. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 21661f6490d6..195cfe557511 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev) } const struct dev_pm_ops tegra_pinctrl_pm = { - .suspend = &tegra_pinctrl_suspend, - .resume = &tegra_pinctrl_resume + .suspend_noirq = &tegra_pinctrl_suspend, + .resume_noirq = &tegra_pinctrl_resume }; static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
Use noirq suspend/resume callbacks as other drivers which implement noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to configure the signals used by their respective devices in the noirq phase. Signed-off-by: Vidya Sagar <vidyas@nvidia.com> --- drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)