diff mbox series

[v1] pinctrl: fix several typos

Message ID 20200419164956.3484-1-zhengdejin5@gmail.com
State New
Headers show
Series [v1] pinctrl: fix several typos | expand

Commit Message

Dejin Zheng April 19, 2020, 4:49 p.m. UTC
use codespell to fix lots of typos over frontends.

CC: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
 drivers/pinctrl/freescale/pinctrl-imx1-core.c    | 2 +-
 drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c | 2 +-
 drivers/pinctrl/pinctrl-lantiq.c                 | 2 +-
 drivers/pinctrl/pinctrl-sx150x.c                 | 2 +-
 drivers/pinctrl/sh-pfc/pfc-sh7269.c              | 2 +-
 drivers/pinctrl/tegra/pinctrl-tegra-xusb.c       | 2 +-
 drivers/pinctrl/zte/pinctrl-zx.c                 | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

Comments

Uwe Kleine-K├Ânig April 19, 2020, 5:10 p.m. UTC | #1
Hello,

On Mon, Apr 20, 2020 at 12:49:56AM +0800, Dejin Zheng wrote:
> use codespell to fix lots of typos over frontends.
> 
> CC: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
>  drivers/pinctrl/freescale/pinctrl-imx1-core.c    | 2 +-
>  drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c | 2 +-
>  drivers/pinctrl/pinctrl-lantiq.c                 | 2 +-
>  drivers/pinctrl/pinctrl-sx150x.c                 | 2 +-
>  drivers/pinctrl/sh-pfc/pfc-sh7269.c              | 2 +-
>  drivers/pinctrl/tegra/pinctrl-tegra-xusb.c       | 2 +-
>  drivers/pinctrl/zte/pinctrl-zx.c                 | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> index c00d0022d311..ec0b1a273f7b 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> @@ -60,7 +60,7 @@ struct imx1_pinctrl {
>  
>  /*
>   * IMX1 IOMUXC manages the pins based on ports. Each port has 32 pins. IOMUX
> - * control register are seperated into function, output configuration, input
> + * control register are separated into function, output configuration, input

Either s/register/registers/ or s/are/is/


>   * configuration A, input configuration B, GPIO in use and data direction.
>   *

Best regards
Uwe
Geert Uytterhoeven April 19, 2020, 5:54 p.m. UTC | #2
On Sun, Apr 19, 2020 at 6:50 PM Dejin Zheng <zhengdejin5@gmail.com> wrote:
> use codespell to fix lots of typos over frontends.
>
> CC: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>

Thanks for your patch!

>  drivers/pinctrl/sh-pfc/pfc-sh7269.c              | 2 +-

For sh-pfc:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/pinctrl/sh-pfc/pfc-sh7269.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7269.c
> @@ -1963,7 +1963,7 @@ static const struct pinmux_func pinmux_func_gpios[] = {
>  static const struct pinmux_cfg_reg pinmux_config_regs[] = {
>         /* "name" addr register_size Field_Width */
>
> -       /* where Field_Width is 1 for single mode registers or 4 for upto 16
> +       /* where Field_Width is 1 for single mode registers or 4 for up to 16
>            mode registers and modes are described in assending order [0..16] */

Which brings my attention to another typo: that range should be [0..15].

Gr{oetje,eeting}s,

                        Geert
Joe Perches April 20, 2020, 4:41 p.m. UTC | #3
On Mon, 2020-04-20 at 00:49 +0800, Dejin Zheng wrote:
> use codespell to fix lots of typos over frontends.
[]
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c b/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c
[]
> @@ -418,7 +418,7 @@ static const unsigned lcdvsi1_a_1_pins[] = { DB8500_PIN_E2 };
>  static const unsigned lcd_d0_d7_a_1_pins[] = {
>  	DB8500_PIN_G5, DB8500_PIN_G4, DB8500_PIN_H4, DB8500_PIN_H3,
>  	DB8500_PIN_J3, DB8500_PIN_H2, DB8500_PIN_J2, DB8500_PIN_H1 };
> -/* D8 thru D11 often used as TVOUT lines */
> +/* D8 through D11 often used as TVOUT lines */

thru is _really_ common and a generally accepted informal
for through so I suggest this not be changed.

https://www.dictionary.com/browse/thru
preposition, adverb, adjective
an informal, simplified spelling of through.

https://www.merriam-webster.com/dictionary/thru
While never extremely common, tho and thru have a long history of
occasional use as spelling variants of though and through.

Their greatest popularity occurred in the late 19th and early 20th 
centuries, when their adoption was advocated by spelling reformers. 
Their current use occurs chiefly in informal writing (as in personal 
letters) and in some technical journals.
Dejin Zheng April 21, 2020, 2:34 p.m. UTC | #4
On Mon, Apr 20, 2020 at 09:41:09AM -0700, Joe Perches wrote:
> On Mon, 2020-04-20 at 00:49 +0800, Dejin Zheng wrote:
> > use codespell to fix lots of typos over frontends.
> []
> > diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c b/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c
> []
> > @@ -418,7 +418,7 @@ static const unsigned lcdvsi1_a_1_pins[] = { DB8500_PIN_E2 };
> >  static const unsigned lcd_d0_d7_a_1_pins[] = {
> >  	DB8500_PIN_G5, DB8500_PIN_G4, DB8500_PIN_H4, DB8500_PIN_H3,
> >  	DB8500_PIN_J3, DB8500_PIN_H2, DB8500_PIN_J2, DB8500_PIN_H1 };
> > -/* D8 thru D11 often used as TVOUT lines */
> > +/* D8 through D11 often used as TVOUT lines */
> 
> thru is _really_ common and a generally accepted informal
> for through so I suggest this not be changed.
> 
> https://www.dictionary.com/browse/thru
> preposition, adverb, adjective
> an informal, simplified spelling of through.
> 
> https://www.merriam-webster.com/dictionary/thru
> While never extremely common, tho and thru have a long history of
> occasional use as spelling variants of though and through.
> 
> Their greatest popularity occurred in the late 19th and early 20th 
> centuries, when their adoption was advocated by spelling reformers. 
> Their current use occurs chiefly in informal writing (as in personal 
> letters) and in some technical journals.
>
Joe, Thanks!
diff mbox series

Patch

diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
index c00d0022d311..ec0b1a273f7b 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
@@ -60,7 +60,7 @@  struct imx1_pinctrl {
 
 /*
  * IMX1 IOMUXC manages the pins based on ports. Each port has 32 pins. IOMUX
- * control register are seperated into function, output configuration, input
+ * control register are separated into function, output configuration, input
  * configuration A, input configuration B, GPIO in use and data direction.
  *
  * Those controls that are represented by 1 bit have a direct mapping between
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c b/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c
index b9246e0b4fe2..508f1b11a4df 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c
@@ -418,7 +418,7 @@  static const unsigned lcdvsi1_a_1_pins[] = { DB8500_PIN_E2 };
 static const unsigned lcd_d0_d7_a_1_pins[] = {
 	DB8500_PIN_G5, DB8500_PIN_G4, DB8500_PIN_H4, DB8500_PIN_H3,
 	DB8500_PIN_J3, DB8500_PIN_H2, DB8500_PIN_J2, DB8500_PIN_H1 };
-/* D8 thru D11 often used as TVOUT lines */
+/* D8 through D11 often used as TVOUT lines */
 static const unsigned lcd_d8_d11_a_1_pins[] = { DB8500_PIN_F4,
 	DB8500_PIN_E3, DB8500_PIN_E4, DB8500_PIN_D2 };
 static const unsigned lcd_d12_d23_a_1_pins[] = {
diff --git a/drivers/pinctrl/pinctrl-lantiq.c b/drivers/pinctrl/pinctrl-lantiq.c
index aa92f141b865..626e02d7a1ba 100644
--- a/drivers/pinctrl/pinctrl-lantiq.c
+++ b/drivers/pinctrl/pinctrl-lantiq.c
@@ -221,7 +221,7 @@  static int match_mux(const struct ltq_mfp_pin *mfp, unsigned mux)
 	return i;
 }
 
-/* dont assume .mfp is linearly mapped. find the mfp with the correct .pin */
+/* don't assume .mfp is linearly mapped. find the mfp with the correct .pin */
 static int match_mfp(const struct ltq_pinmux_info *info, int pin)
 {
 	int i;
diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
index 6e74bd87d959..708bc91862fe 100644
--- a/drivers/pinctrl/pinctrl-sx150x.c
+++ b/drivers/pinctrl/pinctrl-sx150x.c
@@ -988,7 +988,7 @@  static unsigned int sx150x_maybe_swizzle(struct sx150x_pinctrl *pctl,
 /*
  * In order to mask the differences between 16 and 8 bit expander
  * devices we set up a sligthly ficticious regmap that pretends to be
- * a set of 32-bit (to accomodate RegSenseLow/RegSenseHigh
+ * a set of 32-bit (to accommodate RegSenseLow/RegSenseHigh
  * pair/quartet) registers and transparently reconstructs those
  * registers via multiple I2C/SMBus reads
  *
diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7269.c b/drivers/pinctrl/sh-pfc/pfc-sh7269.c
index d20974a55d93..0aed18863ba3 100644
--- a/drivers/pinctrl/sh-pfc/pfc-sh7269.c
+++ b/drivers/pinctrl/sh-pfc/pfc-sh7269.c
@@ -1963,7 +1963,7 @@  static const struct pinmux_func pinmux_func_gpios[] = {
 static const struct pinmux_cfg_reg pinmux_config_regs[] = {
 	/* "name" addr register_size Field_Width */
 
-	/* where Field_Width is 1 for single mode registers or 4 for upto 16
+	/* where Field_Width is 1 for single mode registers or 4 for up to 16
 	   mode registers and modes are described in assending order [0..16] */
 
 	{ PINMUX_CFG_REG("PAIOR0", 0xfffe3812, 16, 1, GROUP(
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
index 6f7b3767f453..43922ab81666 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
@@ -123,7 +123,7 @@  static int tegra_xusb_padctl_get_group_pins(struct pinctrl_dev *pinctrl,
 					    unsigned *num_pins)
 {
 	/*
-	 * For the tegra-xusb pad controller groups are synonomous
+	 * For the tegra-xusb pad controller groups are synonymous
 	 * with lanes/pins and there is always one lane/pin per group.
 	 */
 	*pins = &pinctrl->desc->pins[group].number;
diff --git a/drivers/pinctrl/zte/pinctrl-zx.c b/drivers/pinctrl/zte/pinctrl-zx.c
index 786bf89487d6..80d00ab8c110 100644
--- a/drivers/pinctrl/zte/pinctrl-zx.c
+++ b/drivers/pinctrl/zte/pinctrl-zx.c
@@ -94,7 +94,7 @@  static int zx_set_mux(struct pinctrl_dev *pctldev, unsigned int func_selector,
 	if (data->aon_pin) {
 		/*
 		 * It's an AON pin, whose mux register offset and bit position
-		 * can be caluculated from pin number.  Each register covers 16
+		 * can be calculated from pin number.  Each register covers 16
 		 * pins, and each pin occupies 2 bits.
 		 */
 		u16 aoffset = pindesc->number / 16 * 4;