| Message ID | 20200417092112.12303-1-yanaijie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: remove unused 'pwm37_pins' | expand |
On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@huawei.com> wrote: > Fix the following gcc warning: > > drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined > but not used [-Wunused-const-variable=] > static const unsigned int pwm37_pins[] = { 110 }; > ^~~~~~~~~~ > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> I'm sceptic about this. I think PWM37 exists and just need to be properly defined. Mani will know the right solution to this. Yours, Linus Walleij
On Tue, Apr 28, 2020 at 11:58:01AM +0200, Linus Walleij wrote: > On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@huawei.com> wrote: > > > Fix the following gcc warning: > > > > drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined > > but not used [-Wunused-const-variable=] > > static const unsigned int pwm37_pins[] = { 110 }; > > ^~~~~~~~~~ > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > > I'm sceptic about this. I think PWM37 exists and just need to be > properly defined. > > Mani will know the right solution to this. > Sorry for missing this thread before. The original patch didn't land in my inbox. Anyway the issue is, pwm37 is not added to BM1880_PINCTRL_GRP. So the proper fix would be to add it. Jason, will you be able to send a patch for adding it? Otherwise I'll do that. Thanks, Mani > Yours, > Linus Walleij
在 2020/4/28 19:30, Manivannan Sadhasivam 写道: > On Tue, Apr 28, 2020 at 11:58:01AM +0200, Linus Walleij wrote: >> On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@huawei.com> wrote: >> >>> Fix the following gcc warning: >>> >>> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined >>> but not used [-Wunused-const-variable=] >>> static const unsigned int pwm37_pins[] = { 110 }; >>> ^~~~~~~~~~ >>> >>> Reported-by: Hulk Robot <hulkci@huawei.com> >>> Signed-off-by: Jason Yan <yanaijie@huawei.com> >> >> I'm sceptic about this. I think PWM37 exists and just need to be >> properly defined. >> >> Mani will know the right solution to this. >> > > Sorry for missing this thread before. The original patch didn't land in my > inbox. > > Anyway the issue is, pwm37 is not added to BM1880_PINCTRL_GRP. So the proper > fix would be to add it. > > Jason, will you be able to send a patch for adding it? Otherwise I'll do that. > OK, I will send v2 soon. Thanks, Jason > Thanks, > Mani > >> Yours, >> Linus Walleij >
diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c index f7dff4f14101..80bc04f40964 100644 --- a/drivers/pinctrl/pinctrl-bm1880.c +++ b/drivers/pinctrl/pinctrl-bm1880.c @@ -260,7 +260,6 @@ static const unsigned int pwm33_pins[] = { 106 }; static const unsigned int pwm34_pins[] = { 107 }; static const unsigned int pwm35_pins[] = { 108 }; static const unsigned int pwm36_pins[] = { 109 }; -static const unsigned int pwm37_pins[] = { 110 }; static const unsigned int i2c0_pins[] = { 63, 64 }; static const unsigned int i2c1_pins[] = { 65, 66 }; static const unsigned int i2c2_pins[] = { 67, 68 };
Fix the following gcc warning: drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined but not used [-Wunused-const-variable=] static const unsigned int pwm37_pins[] = { 110 }; ^~~~~~~~~~ Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/pinctrl/pinctrl-bm1880.c | 1 - 1 file changed, 1 deletion(-)