| Message ID | 20200313034244.26336-1-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: mvebu: avoid error message for optional IRQ | expand |
Hello, On Fri, Mar 13, 2020 at 04:42:44PM +1300, Chris Packham wrote: > platform_get_irq() will generate an error message if the requested irq > is not present > > mvebu-gpio f1010140.gpio: IRQ index 3 not found > > use platform_get_irq_optional() to avoid the error message being > generated. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> LGTM Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
pt., 13 mar 2020 o 04:42 Chris Packham <chris.packham@alliedtelesis.co.nz> napisał(a): > > platform_get_irq() will generate an error message if the requested irq > is not present > > mvebu-gpio f1010140.gpio: IRQ index 3 not found > > use platform_get_irq_optional() to avoid the error message being > generated. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > drivers/gpio/gpio-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c > index d2b999c7987f..3c9f4fb3d5a2 100644 > --- a/drivers/gpio/gpio-mvebu.c > +++ b/drivers/gpio/gpio-mvebu.c > @@ -1247,7 +1247,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) > * pins. > */ > for (i = 0; i < 4; i++) { > - int irq = platform_get_irq(pdev, i); > + int irq = platform_get_irq_optional(pdev, i); > > if (irq < 0) > continue; > -- > 2.25.1 > Patch applied, thanks! Bartosz
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index d2b999c7987f..3c9f4fb3d5a2 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1247,7 +1247,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) * pins. */ for (i = 0; i < 4; i++) { - int irq = platform_get_irq(pdev, i); + int irq = platform_get_irq_optional(pdev, i); if (irq < 0) continue;
platform_get_irq() will generate an error message if the requested irq is not present mvebu-gpio f1010140.gpio: IRQ index 3 not found use platform_get_irq_optional() to avoid the error message being generated. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- drivers/gpio/gpio-mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)