From patchwork Wed Feb 19 09:22:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 1240576 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=kN4ndebW; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48Msgs5rdhz9sRk for ; Wed, 19 Feb 2020 20:22:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbgBSJWc (ORCPT ); Wed, 19 Feb 2020 04:22:32 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35041 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726762AbgBSJWb (ORCPT ); Wed, 19 Feb 2020 04:22:31 -0500 Received: by mail-wr1-f66.google.com with SMTP id w12so27298918wrt.2 for ; Wed, 19 Feb 2020 01:22:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=odwKwtP2lE8W97hrRy8NvVzj5zWj2rVZZDM+vhqGNzE=; b=kN4ndebWVxSAl3I2DeNQFdgtH5aq0q9L9+oarqqkG+xsMTE62bhik4iJ5XqnBoF5q/ /3bTEIpaKsDjo5fe3hIBVllyXv2UYDc+nPURBs9sRjQZnN0IdlUUrmFd1BJfugsPaXrq mtBPLync0/t3eexaWGxSkfGEnQ92QuvCo3HvszjoF3EV4G5WQezQ//rTaE9SW5AQHwIO zxT6/snlUIoVoAQDU1bx3D8WpRpRfNkO47tIPosDKUPfCxmnBkvkZcJnXxsIoqP8SsTb 1sMBgyv4tnBUqj7PzzrodZSdkviZj1l/c17AWmjk1XumhemE5nv3uDZmcQ6jy7gfzabS CI/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=odwKwtP2lE8W97hrRy8NvVzj5zWj2rVZZDM+vhqGNzE=; b=Lb7h5MGRnTdkdKKRhTYEPgKFlrMEgmtyTkLgEtEZm2zihRX6Uj5cvcfUD/0RdkORXp XNDWINhNG6W9p3MfhxtYYYxP7NAAA1jOZyicb+hwT8rgxJMNQa9PUVccr3bifZCLT/lP OojhN/tX2h0DmtaJz1slhd+A/QOGYbjpKi13Fvkk8lQRqIyQMQ8ssX+Vw0eXakQa8pJQ 0SjIlF+QJxcYAwocrw6A5UWDs/G4tCk+Zzr5ZUIg3L5gJrUjstyeitpwdiabi2m+SKhf mf3N1vUwHjh7qu4QhG5wTEpygs1FmeL9Dm9uH2tnQlErHPDBQiVFgtNjThGohLB+0kbk 2+kw== X-Gm-Message-State: APjAAAWIpUwCn+Ta5vAXbRNn/+r5ZRcnGDxefdYWSppkN2qCXFXGb2kt YLhHDP49ounZAQ8c20DMNpCvaw== X-Google-Smtp-Source: APXvYqzMAsBMU+3D/XofaGr4QgydoNbC5+5IkqGNjXo2HITsljiwnnn5pJgC9o9DjsVBK+fpvaklTw== X-Received: by 2002:a5d:6709:: with SMTP id o9mr33982122wru.82.1582104149172; Wed, 19 Feb 2020 01:22:29 -0800 (PST) Received: from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr. [2.15.156.232]) by smtp.gmail.com with ESMTPSA id s65sm2172296wmf.48.2020.02.19.01.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 01:22:28 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Srinivas Kandagatla , Khouloud Touil , Geert Uytterhoeven Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 7/7] nvmem: add a comment about resource management Date: Wed, 19 Feb 2020 10:22:18 +0100 Message-Id: <20200219092218.18143-8-brgl@bgdev.pl> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200219092218.18143-1-brgl@bgdev.pl> References: <20200219092218.18143-1-brgl@bgdev.pl> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Bartosz Golaszewski The fact that part of the resources associated with the nvmem resources is freed by the release() callback in device_type caused me some confusion. Add a comment explaining that to nvmem_register(). Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 40fe5913c264..6e28f3fddf53 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -397,6 +397,11 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name); + /* + * After calling device_add() we can stop freeing previously + * allocated resources - they'll be freed from nvmem_release() + * when the device's reference count drops to 0. + */ rval = device_add(&nvmem->dev); if (rval) goto err_put_device;