Message ID | 20200218094234.23896-6-brgl@bgdev.pl |
---|---|
State | New |
Headers | show |
Series | nvmem/gpio: fix resource management | expand |
On 18/02/2020 09:42, Bartosz Golaszewski wrote: > @@ -428,6 +429,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) > device_del(&nvmem->dev); > err_put_device: > put_device(&nvmem->dev); > + gpiod_put(nvmem->wp_gpio); > err_ida_remove: > ida_simple_remove(&nvmem_ida, nvmem->id); > err_free_nvmem: This is also redundant as explained in my previous comments about release() --srini > --
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index c4a6c044b020..e47152e9db34 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -72,6 +72,7 @@ static void nvmem_release(struct device *dev) struct nvmem_device *nvmem = to_nvmem_device(dev); ida_simple_remove(&nvmem_ida, nvmem->id); + gpiod_put(nvmem->wp_gpio); kfree(nvmem); } @@ -428,6 +429,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) device_del(&nvmem->dev); err_put_device: put_device(&nvmem->dev); + gpiod_put(nvmem->wp_gpio); err_ida_remove: ida_simple_remove(&nvmem_ida, nvmem->id); err_free_nvmem: