| Message ID | 20200131122918.7127-1-axel.lin@ingics.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpio: wcd934x: Don't change gpio direction in wcd_gpio_set | expand |
Thanks for the patch! On 31/01/2020 12:29, Axel Lin wrote: > The .set callback should just set output value. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Hi Srinivas, > I don't have this h/w to test, so please help to review and test the patchs. > Thanks, > Axel > drivers/gpio/gpio-wcd934x.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c > index 74913f2e5697..9d4ec8941b9b 100644 > --- a/drivers/gpio/gpio-wcd934x.c > +++ b/drivers/gpio/gpio-wcd934x.c > @@ -66,7 +66,10 @@ static int wcd_gpio_get(struct gpio_chip *chip, unsigned int pin) > > static void wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) > { > - wcd_gpio_direction_output(chip, pin, val); > + struct wcd_gpio_data *data = gpiochip_get_data(chip); > + > + regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, > + WCD_PIN_MASK(pin), val ? WCD_PIN_MASK(pin) : 0); > } > > static int wcd_gpio_probe(struct platform_device *pdev) >
wt., 4 lut 2020 o 11:32 Srinivas Kandagatla <srinivas.kandagatla@linaro.org> napisał(a): > > Thanks for the patch! > > On 31/01/2020 12:29, Axel Lin wrote: > > The .set callback should just set output value. > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Applied with Srinivas' tag. Bartosz
diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index 74913f2e5697..9d4ec8941b9b 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -66,7 +66,10 @@ static int wcd_gpio_get(struct gpio_chip *chip, unsigned int pin) static void wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) { - wcd_gpio_direction_output(chip, pin, val); + struct wcd_gpio_data *data = gpiochip_get_data(chip); + + regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, + WCD_PIN_MASK(pin), val ? WCD_PIN_MASK(pin) : 0); } static int wcd_gpio_probe(struct platform_device *pdev)
The .set callback should just set output value. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Hi Srinivas, I don't have this h/w to test, so please help to review and test the patchs. Thanks, Axel drivers/gpio/gpio-wcd934x.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)