| Message ID | 20200108161620.80105-1-joyce.ooi@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: altera: change to platform_get_irq_optional to avoid false-positive error | expand |
śr., 8 sty 2020 o 17:16 Ooi, Joyce <joyce.ooi@intel.com> napisał(a): > > This patch switches to platform_get_irq_optional() from > platform_get_irq() as it causes a false-positive error such as 'IRQ > index 0 not found' when IRQ is not used. The IRQ usage is optional in > this gpio-altera driver, so the error log is undesirable. > > Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com> Patch applied, thanks! Bartosz
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index 9f2e6b04c361..cc4ba71e4fe3 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -266,7 +266,7 @@ static int altera_gpio_probe(struct platform_device *pdev) altera_gc->mmchip.gc.owner = THIS_MODULE; altera_gc->mmchip.gc.parent = &pdev->dev; - altera_gc->mapped_irq = platform_get_irq(pdev, 0); + altera_gc->mapped_irq = platform_get_irq_optional(pdev, 0); if (altera_gc->mapped_irq < 0) goto skip_irq;
This patch switches to platform_get_irq_optional() from platform_get_irq() as it causes a false-positive error such as 'IRQ index 0 not found' when IRQ is not used. The IRQ usage is optional in this gpio-altera driver, so the error log is undesirable. Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com> --- drivers/gpio/gpio-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)