| Message ID | 20191218110456.2533088-1-ben.dooks@codethink.co.uk |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: tegra: fix missing __iomem in suspend/resume | expand |
18.12.2019 14:04, Ben Dooks (Codethink) пишет: > The functions should have __iomem on the register pointer > so add that to silence the following sparse warnings: > > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] * > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] * > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > --- > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: linux-gpio@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c > index 692d8b3e2a20..cefbbb8d1a68 100644 > --- a/drivers/pinctrl/tegra/pinctrl-tegra.c > +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c > @@ -648,7 +648,7 @@ static int tegra_pinctrl_suspend(struct device *dev) > { > struct tegra_pmx *pmx = dev_get_drvdata(dev); > u32 *backup_regs = pmx->backup_regs; > - u32 *regs; > + u32 __iomem *regs; > size_t bank_size; > unsigned int i, k; > > @@ -666,7 +666,7 @@ static int tegra_pinctrl_resume(struct device *dev) > { > struct tegra_pmx *pmx = dev_get_drvdata(dev); > u32 *backup_regs = pmx->backup_regs; > - u32 *regs; > + u32 __iomem *regs; > size_t bank_size; > unsigned int i, k; > > Looks good! Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
On Wed, Dec 18, 2019 at 11:04:56AM +0000, Ben Dooks (Codethink) wrote: > The functions should have __iomem on the register pointer > so add that to silence the following sparse warnings: > > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] * > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] * > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > --- > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: linux-gpio@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Wed, Dec 18, 2019 at 12:04 PM Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> wrote: > The functions should have __iomem on the register pointer > so add that to silence the following sparse warnings: > > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] * > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] * > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > --- > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: linux-gpio@vger.kernel.org > Cc: linux-tegra@vger.kernel.org Patch applied with the ACKs. Yours, Linus Walleij
On 06/01/2020 23:00, Linus Walleij wrote: > On Wed, Dec 18, 2019 at 12:04 PM Ben Dooks (Codethink) > <ben.dooks@codethink.co.uk> wrote: > >> The functions should have __iomem on the register pointer >> so add that to silence the following sparse warnings: >> > Patch applied with the ACKs. > > Yours, > Linus Walleij Thank you.
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 692d8b3e2a20..cefbbb8d1a68 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -648,7 +648,7 @@ static int tegra_pinctrl_suspend(struct device *dev) { struct tegra_pmx *pmx = dev_get_drvdata(dev); u32 *backup_regs = pmx->backup_regs; - u32 *regs; + u32 __iomem *regs; size_t bank_size; unsigned int i, k; @@ -666,7 +666,7 @@ static int tegra_pinctrl_resume(struct device *dev) { struct tegra_pmx *pmx = dev_get_drvdata(dev); u32 *backup_regs = pmx->backup_regs; - u32 *regs; + u32 __iomem *regs; size_t bank_size; unsigned int i, k;
The functions should have __iomem on the register pointer so add that to silence the following sparse warnings: drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces) drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> * drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces) drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] * drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces) drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> * drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces) drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] * Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Dmitry Osipenko <digetx@gmail.com> Cc: linux-gpio@vger.kernel.org Cc: linux-tegra@vger.kernel.org --- drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)