| Message ID | 20191113084352.GA25535@localhost.localdomain |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: mmio: remove untrue leftover comment | expand |
śr., 13 lis 2019 o 09:44 Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> napisał(a): > > The comment should have been removed when new GPIO direction > definitions were taken in use as the function logic was changed. It > is now perfectly valid and Ok to hit the return from the bottom of > the direction getting function. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > > Sorry guys. Just noticed that I should've removed this comment in > original patch series. > > drivers/gpio/gpio-mmio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c > index cd07c948649f..f729e3e9e983 100644 > --- a/drivers/gpio/gpio-mmio.c > +++ b/drivers/gpio/gpio-mmio.c > @@ -386,7 +386,6 @@ static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio) > if (!(gc->read_reg(gc->reg_dir_in) & bgpio_line2mask(gc, gpio))) > return GPIO_LINE_DIRECTION_OUT; > > - /* This should not happen */ > return GPIO_LINE_DIRECTION_IN; > } > > > base-commit: 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =] Queued for v5.5, thanks! Bartosz
diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c index cd07c948649f..f729e3e9e983 100644 --- a/drivers/gpio/gpio-mmio.c +++ b/drivers/gpio/gpio-mmio.c @@ -386,7 +386,6 @@ static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio) if (!(gc->read_reg(gc->reg_dir_in) & bgpio_line2mask(gc, gpio))) return GPIO_LINE_DIRECTION_OUT; - /* This should not happen */ return GPIO_LINE_DIRECTION_IN; }
The comment should have been removed when new GPIO direction definitions were taken in use as the function logic was changed. It is now perfectly valid and Ok to hit the return from the bottom of the direction getting function. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- Sorry guys. Just noticed that I should've removed this comment in original patch series. drivers/gpio/gpio-mmio.c | 1 - 1 file changed, 1 deletion(-) base-commit: 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c