| Message ID | 20190718065101.26994-1-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: refactor gpiochip_allocate_mask() with bitmap_alloc() | expand |
Quoting Masahiro Yamada (2019-07-17 23:51:01) > Refactor gpiochip_allocate_mask() slightly by using bitmap_alloc(). > > I used bitmap_free() for the corresponding free parts. Actually, > bitmap_free() is a wrapper of kfree(), but I did this for consistency. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On Thu, Jul 18, 2019 at 8:51 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Refactor gpiochip_allocate_mask() slightly by using bitmap_alloc(). > > I used bitmap_free() for the corresponding free parts. Actually, > bitmap_free() is a wrapper of kfree(), but I did this for consistency. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Patch applied with Stephen's ACK. Yours, Linus Walleij
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 3ee99d070608..5ac2daa01a53 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -350,7 +350,7 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip) { unsigned long *p; - p = kmalloc_array(BITS_TO_LONGS(chip->ngpio), sizeof(*p), GFP_KERNEL); + p = bitmap_alloc(chip->ngpio, GFP_KERNEL); if (!p) return NULL; @@ -391,7 +391,7 @@ static int gpiochip_init_valid_mask(struct gpio_chip *gpiochip) static void gpiochip_free_valid_mask(struct gpio_chip *gpiochip) { - kfree(gpiochip->valid_mask); + bitmap_free(gpiochip->valid_mask); gpiochip->valid_mask = NULL; } @@ -1626,7 +1626,7 @@ static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip) static void gpiochip_irqchip_free_valid_mask(struct gpio_chip *gpiochip) { - kfree(gpiochip->irq.valid_mask); + bitmap_free(gpiochip->irq.valid_mask); gpiochip->irq.valid_mask = NULL; }
Refactor gpiochip_allocate_mask() slightly by using bitmap_alloc(). I used bitmap_free() for the corresponding free parts. Actually, bitmap_free() is a wrapper of kfree(), but I did this for consistency. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/gpio/gpiolib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)