| Message ID | 20190705143043.1929-1-luca@lucaceresoli.net |
|---|---|
| State | New |
| Headers | show |
| Series | docs/pinctrl: fix compile errors in example code | expand |
On Fri, Jul 5, 2019 at 4:30 PM Luca Ceresoli <luca@lucaceresoli.net> wrote: > The code in the example does not build for a few trivial errors: type > mismatch in callback, missing semicolon. Fix them to help newcomers using > the example as a starting point. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> Patch applied. Yours, Linus Walleij
diff --git a/Documentation/driver-api/pinctl.rst b/Documentation/driver-api/pinctl.rst index 2bb1bc484278..3d2deaf48841 100644 --- a/Documentation/driver-api/pinctl.rst +++ b/Documentation/driver-api/pinctl.rst @@ -638,8 +638,8 @@ group of pins would work something like this:: } static int foo_get_group_pins(struct pinctrl_dev *pctldev, unsigned selector, - unsigned ** const pins, - unsigned * const num_pins) + const unsigned ** pins, + unsigned * num_pins) { *pins = (unsigned *) foo_groups[selector].pins; *num_pins = foo_groups[selector].num_pins; @@ -705,7 +705,7 @@ group of pins would work something like this:: { u8 regbit = (1 << selector + group); - writeb((readb(MUX)|regbit), MUX) + writeb((readb(MUX)|regbit), MUX); return 0; }
The code in the example does not build for a few trivial errors: type mismatch in callback, missing semicolon. Fix them to help newcomers using the example as a starting point. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- Documentation/driver-api/pinctl.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)