diff mbox series

[2/2] pinctrl: make pinconf.h self-contained

Message ID 20190613015532.19685-2-yamada.masahiro@socionext.com
State New
Headers show
Series [1/2] pinctrl: remove unneeded #ifdef around declarations | expand

Commit Message

Masahiro Yamada June 13, 2019, 1:55 a.m. UTC
This header uses 'bool', but it does not include any header by itself.

So, it could cause unknown type name error, depending on the header
include order, although probably <linux/types.h> has been included by
someone else.

Include <linux/types.h> to make it self-contained.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/linux/pinctrl/pinconf.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Linus Walleij June 18, 2019, 11:45 a.m. UTC | #1
On Thu, Jun 13, 2019 at 3:55 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> This header uses 'bool', but it does not include any header by itself.
>
> So, it could cause unknown type name error, depending on the header
> include order, although probably <linux/types.h> has been included by
> someone else.
>
> Include <linux/types.h> to make it self-contained.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/include/linux/pinctrl/pinconf.h b/include/linux/pinctrl/pinconf.h
index eb16a1e0bcfa..f8a8215e9021 100644
--- a/include/linux/pinctrl/pinconf.h
+++ b/include/linux/pinctrl/pinconf.h
@@ -11,6 +11,8 @@ 
 #ifndef __LINUX_PINCTRL_PINCONF_H
 #define __LINUX_PINCTRL_PINCONF_H
 
+#include <linux/types.h>
+
 struct pinctrl_dev;
 struct seq_file;