diff mbox series

[v2,2/3] gpio: davinci: Add new compatible for K3 AM654 SoCs

Message ID 20190605080259.2462-3-j-keerthy@ti.com
State New
Headers show
Series gpio: davinci: Add support for TI K3 AM6 platform | expand

Commit Message

J, KEERTHY June 5, 2019, 8:02 a.m. UTC
Add new compatible for K3 AM654 SoCs.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/gpio/gpio-davinci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bartosz Golaszewski June 5, 2019, 2:26 p.m. UTC | #1
śr., 5 cze 2019 o 10:02 Keerthy <j-keerthy@ti.com> napisał(a):
>
> Add new compatible for K3 AM654 SoCs.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/gpio/gpio-davinci.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 0977590eb996..fc494a84a29d 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -632,6 +632,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
>
>  static const struct of_device_id davinci_gpio_ids[] = {
>         { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
> +       { .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},

Please add a patch adding this compatible to the binding document as well.

Bart

>         { .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
>         { /* sentinel */ },
>  };
> --
> 2.17.1
>
J, KEERTHY June 5, 2019, 3:13 p.m. UTC | #2
On 05/06/19 7:56 PM, Bartosz Golaszewski wrote:
> śr., 5 cze 2019 o 10:02 Keerthy <j-keerthy@ti.com> napisał(a):
>>
>> Add new compatible for K3 AM654 SoCs.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   drivers/gpio/gpio-davinci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 0977590eb996..fc494a84a29d 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -632,6 +632,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
>>
>>   static const struct of_device_id davinci_gpio_ids[] = {
>>          { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
>> +       { .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},
> 
> Please add a patch adding this compatible to the binding document as well.

https://patchwork.kernel.org/patch/10976445/

Posted but did not add you in Cc. Sorry about that.

- Keerthy
> 
> Bart
> 
>>          { .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
>>          { /* sentinel */ },
>>   };
>> --
>> 2.17.1
>>
Bartosz Golaszewski June 6, 2019, 7:49 a.m. UTC | #3
śr., 5 cze 2019 o 17:12 Keerthy <j-keerthy@ti.com> napisał(a):
>
>
>
> On 05/06/19 7:56 PM, Bartosz Golaszewski wrote:
> > śr., 5 cze 2019 o 10:02 Keerthy <j-keerthy@ti.com> napisał(a):
> >>
> >> Add new compatible for K3 AM654 SoCs.
> >>
> >> Signed-off-by: Keerthy <j-keerthy@ti.com>
> >> ---
> >>   drivers/gpio/gpio-davinci.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> >> index 0977590eb996..fc494a84a29d 100644
> >> --- a/drivers/gpio/gpio-davinci.c
> >> +++ b/drivers/gpio/gpio-davinci.c
> >> @@ -632,6 +632,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> >>
> >>   static const struct of_device_id davinci_gpio_ids[] = {
> >>          { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
> >> +       { .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},
> >
> > Please add a patch adding this compatible to the binding document as well.
>
> https://patchwork.kernel.org/patch/10976445/
>
> Posted but did not add you in Cc. Sorry about that.
>

I don't see it on GPIO patchwork either. Please resend it as part of
this series.

Bart
Linus Walleij June 7, 2019, 10:36 p.m. UTC | #4
On Wed, Jun 5, 2019 at 10:02 AM Keerthy <j-keerthy@ti.com> wrote:

> Add new compatible for K3 AM654 SoCs.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>

Patch applied.

Yours,
Linus Walleij
Linus Walleij June 7, 2019, 10:38 p.m. UTC | #5
On Thu, Jun 6, 2019 at 9:49 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> śr., 5 cze 2019 o 17:12 Keerthy <j-keerthy@ti.com> napisał(a):

> > >>   static const struct of_device_id davinci_gpio_ids[] = {
> > >>          { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
> > >> +       { .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},
> > >
> > > Please add a patch adding this compatible to the binding document as well.
> >
> > https://patchwork.kernel.org/patch/10976445/
> >
> > Posted but did not add you in Cc. Sorry about that.
>
> I don't see it on GPIO patchwork either. Please resend it as part of
> this series.

I see the whole other series got resent as RFC, I'll just apply these
three and the binding patch so we don't have to pingpong these
patches too much around :)

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 0977590eb996..fc494a84a29d 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -632,6 +632,7 @@  static int davinci_gpio_irq_setup(struct platform_device *pdev)
 
 static const struct of_device_id davinci_gpio_ids[] = {
 	{ .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
+	{ .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},
 	{ .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
 	{ /* sentinel */ },
 };