[1/4] pinctrl: sh-pfc: Correct printk level of group referral warning

Fixes: 6161b39a14380815 ("pinctrl: sh-pfc: Validate pinmux tables at runtime when debugging")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/sh-pfc/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

On Thu, Apr 25, 2019 at 11:55:39AM +0200, Geert Uytterhoeven wrote:
> Fixes: 6161b39a14380815 ("pinctrl: sh-pfc: Validate pinmux tables at runtime when debugging")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

This looks good to me

Reviewed-by: Simon Horman <simon.horman@netronome.com>

But I do wonder if "referred" should be "referenced"

> ---
>  drivers/pinctrl/sh-pfc/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 3f989f5cb021ecbc..18d7f6d9402093d4 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -803,8 +803,8 @@ static void sh_pfc_check_info(const struct sh_pfc_soc_info *info)
>  			       info->groups[i].name);
>  			sh_pfc_errors++;
>  		} else if (refcnts[i] > 1) {
> -			pr_err("%s: group %s referred by %u functions\n",
> -			       drvname, info->groups[i].name, refcnts[i]);
> +			pr_warn("%s: group %s referred by %u functions\n",
> +				drvname, info->groups[i].name, refcnts[i]);
>  			sh_pfc_warnings++;
>  		}
>  	}
> -- 
> 2.17.1
>

Hi Simon,

On Fri, Apr 26, 2019 at 11:21 AM Simon Horman <horms@verge.net.au> wrote:
> On Thu, Apr 25, 2019 at 11:55:39AM +0200, Geert Uytterhoeven wrote:
> > Fixes: 6161b39a14380815 ("pinctrl: sh-pfc: Validate pinmux tables at runtime when debugging")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> This looks good to me
>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>

Thanks!

Is the atypical email address for sh-pfc reviews intentional?

> But I do wonder if "referred" should be "referenced"

Yes, sounds better.

Gr{oetje,eeting}s,

                        Geert

On Mon, Apr 29, 2019 at 10:38:52AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Apr 26, 2019 at 11:21 AM Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Apr 25, 2019 at 11:55:39AM +0200, Geert Uytterhoeven wrote:

...

> Thanks!
> 
> Is the atypical email address for sh-pfc reviews intentional?

Sorry about that, I meant this:

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> > But I do wonder if "referred" should be "referenced"
> 
> Yes, sounds better.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>