From patchwork Thu Mar 28 11:00:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 1068004 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="X5n4D/bJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44VMNp3Msbz9sR3 for ; Thu, 28 Mar 2019 22:00:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbfC1LAs (ORCPT ); Thu, 28 Mar 2019 07:00:48 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42982 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfC1LAr (ORCPT ); Thu, 28 Mar 2019 07:00:47 -0400 Received: by mail-wr1-f68.google.com with SMTP id g3so18817319wrx.9 for ; Thu, 28 Mar 2019 04:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7PEBtoNKLgx0deDJdkAZ2nPjH5Bf62HdoDJrD4J/cks=; b=X5n4D/bJXqwEYAzK15BfhFXIK1pQWiKFB8FIDG6sjGcgiC/3j56V2ouIef47j9nhRT G1souaJJhvs4+SbY/4uJcRotu4/pVdX7GrEBiRjuLrsNSxW+uFu3c8q8tH6C2BjkYiBF Ri69haTwlrYw3jztaCHvwjJb0MZtRI3r6key1lmhQMFcI2cDS/7WoQT9zsTA0PNGghIy X7V81Dn0j155gXs7k8L7fryxXsZH2DCSGKzYDt5XckHstwiK3UuMcwvDTzteO6I/5Idu loJpsyXKIdJOz3PP45yFFRE2DPORPXZsX0Y5vezkMIwGKstA8XErmdGflDslNNxMS/iD qzUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7PEBtoNKLgx0deDJdkAZ2nPjH5Bf62HdoDJrD4J/cks=; b=NyV1FvM+jLk6zweSsCBwirsmMsA471nD6ulQ3/Kua2v70cSRU8xZv5mC9j137cIS71 G8SHQYrJNqXpfSk/4GnbDU6UKqMX6x12WMZ61ix0oeNkZiPaIVPdvp8I/6ryR/9UdIlm s9CoLnLfo29PBZuPqE4m69LYqrppZvWqB14rp6kRltbpI8RM8J75rhq6CiLjcJoRVmdF 2Rz7io+QXWD0g3xFWcV38KZFQJpnRfwaBaXgeLPd4zqee/BgKFaV4HRlrDhPb2yhvgKs ATcxeJE5x5u3BX9fVTMh3aEhP4Xc8ZQWOeo4lS8AF1vbXnfzmye0zFfb/9eEo5EpX4GJ +r/g== X-Gm-Message-State: APjAAAWz9/u2G6iPn+Fxa0L9SueEypb/Lk9Yqehuh1LLDCoW0lR8Ivp3 dKy/Pyf4TKXylZwCzhJ8FVTrMA== X-Google-Smtp-Source: APXvYqx7zGorUgWGwTNcv0L4mNGkeNbt9g86FvdKEE9f37DBaZrI3puNvM0LunUMHSB1+IW4nRhgFw== X-Received: by 2002:adf:efc1:: with SMTP id i1mr1798112wrp.199.1553770846015; Thu, 28 Mar 2019 04:00:46 -0700 (PDT) Received: from localhost.localdomain (aputeaux-684-1-20-74.w90-86.abo.wanadoo.fr. [90.86.223.74]) by smtp.gmail.com with ESMTPSA id d14sm24273035wro.79.2019.03.28.04.00.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 04:00:45 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] gpio: mockup: use simple_read_from_buffer() in debugfs read callback Date: Thu, 28 Mar 2019 12:00:43 +0100 Message-Id: <20190328110043.13391-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Bartosz Golaszewski Calling read() for a single byte read will return 2 currently. Use simple_read_from_buffer() which correctly handles all sizes. Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") Signed-off-by: Bartosz Golaszewski Reviewed-by: Mukesh Ojha --- drivers/gpio/gpio-mockup.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 74ba8b1d71d8..859585dce5c9 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -219,12 +219,7 @@ static ssize_t gpio_mockup_debugfs_read(struct file *file, val = gpio_mockup_get(gc, priv->offset); cnt = snprintf(buf, sizeof(buf), "%d\n", val); - rv = copy_to_user(usr_buf, buf, cnt); - if (rv) - return rv; - - *ppos += cnt; - return cnt; + return simple_read_from_buffer(usr_buf, size, ppos, buf, cnt); } static ssize_t gpio_mockup_debugfs_write(struct file *file,