From patchwork Sun Mar 24 23:10:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 1063530 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="VL9mENzP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44SCmD5CbMz9sSH for ; Mon, 25 Mar 2019 10:10:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729036AbfCXXKM (ORCPT ); Sun, 24 Mar 2019 19:10:12 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:49616 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729039AbfCXXKK (ORCPT ); Sun, 24 Mar 2019 19:10:10 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 862C363F for ; Sun, 24 Mar 2019 23:10:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kkFwuz54JwdS for ; Sun, 24 Mar 2019 18:10:08 -0500 (CDT) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 5A2C6625 for ; Sun, 24 Mar 2019 18:10:08 -0500 (CDT) Received: by mail-io1-f70.google.com with SMTP id s184so6513844iod.23 for ; Sun, 24 Mar 2019 16:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=GFuI5+RxpdKf7NbqYWML+tnl7qVmbDtvtw+sDjvanbg=; b=VL9mENzPoTUnyXLjPexCQ2dZFktMRsbKO+ImWUnKwK/sMp7Aup2RXoOMhVLPGNDBrm 1Kh7WvRCjWUXgbU+2Cp/JJa36eR/hI7RGVwUrTZ4+jQO65JlnHMtzDwZRCPgWMSvH15l 80XXxnJ59ul26KDDKc3uMbxT2vue3AVUjmgBOAh/xqhGkVTlzCDoOs2ByhjSpV/8151L mXRkvh0uTXlqaT5/Mw7g/Rzbmhj6W9uwIaFmMvspu3b89PSw0FagiVQvzgeEYDK/38uE +mW6E+c6qiWtHp7EU+/5A4TmQcypZ3nND6ouzK0VMz2pgncuQM8Ey5MC64uDby1FbpfG q7yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GFuI5+RxpdKf7NbqYWML+tnl7qVmbDtvtw+sDjvanbg=; b=T71HKdZ9NubkXzZ/Ao4iUiGKq7lYDbzA70hiN3Et9tC2mRGSRco3qTs2hNkjLo1mzF B+5kYevXZcGy0E0bEEcS9HPKQerw2ktRk0vtIuTQFzD8lZiacKrykg80iRjnLZsvbPY+ W8HO8BdxdN30Juwy/d6HiL+m5hlvesO6xnQpbZRyog50Qaz8tPaINhgEyVLpnA4fvfBd 3eyf2UnDmrJpNWBouQWj2ZLckQ5fjCbzJAwHetEQ+Jd6luHO42JcqwjjkuLWNa3adEkq fGMy4WwdFiDBn/Of4LSlfKzgx5MvlEEPkX7KYlnLMbKcTKWg02mqhWBN+LIDuQUTLmk7 pdVw== X-Gm-Message-State: APjAAAWlsDj2veX6u1YJuNtF5UuuYHrf3oAv1HPmph/iFtdE1/ZBAdws yrfm5gViyUk9uyFxqfgmsuUgUW9JsOOjq2NYZ/d8H5QYw22/Mw0mtHdwF+Dzx8H+yWaldRJGP35 Rp+pizqxYOgL/02Y/TvjStyjQpw== X-Received: by 2002:a02:b60b:: with SMTP id h11mr16219036jam.125.1553469007974; Sun, 24 Mar 2019 16:10:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8aw+DKyd/uMPAWUkRpDqFT+9EceV4jBjtO1GE2nJOCVEbaCOzQZ7ous75xLI92Wlw68ynvA== X-Received: by 2002:a02:b60b:: with SMTP id h11mr16219026jam.125.1553469007782; Sun, 24 Mar 2019 16:10:07 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id x79sm4313839ita.17.2019.03.24.16.10.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 16:10:07 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Linus Walleij , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: fix a potential NULL pointer dereference Date: Sun, 24 Mar 2019 18:10:02 -0500 Message-Id: <20190324231002.2106-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org In case devm_kzalloc, the patch returns ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu Reviewed-by: Andrew Jeffery --- drivers/gpio/gpio-aspeed.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 854bce4fb9e7..217507002dbc 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -1224,6 +1224,8 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev) gpio->offset_timer = devm_kzalloc(&pdev->dev, gpio->chip.ngpio, GFP_KERNEL); + if (!gpio->offset_timer) + return -ENOMEM; return aspeed_gpio_setup_irqs(gpio, pdev); }