From patchwork Wed Jan 23 00:00:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 1029599 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ingics.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b="bRnmAU4T"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43klpk680Dz9sDB for ; Wed, 23 Jan 2019 11:02:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727405AbfAWACd (ORCPT ); Tue, 22 Jan 2019 19:02:33 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36035 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfAWABR (ORCPT ); Tue, 22 Jan 2019 19:01:17 -0500 Received: by mail-pl1-f195.google.com with SMTP id g9so180360plo.3 for ; Tue, 22 Jan 2019 16:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=8CS82FfkB9JXdRghUtrClaDPpv2xNpqImOYlNcTMsds=; b=bRnmAU4TEfsexjonahhgbqY8TWmq2hEr/W7c8x7WweOBkVoGHEMJ420wGki+h/MDrb ycirYGTevwQkrjPsoffarWPy1HATR3vhEx2TlTeGxBaThohGu7kpnvmY0321l0EsbCoB zRzF1+kCu0Fx2TaYoXSnIZRxzgMJjGvYorTb1jzLMLYqArk4En/153tSzJvuN7jewpSO yayI6tk+kuqftwAnd+SmRDJEF4CPjJnHj6eKIVLkdKQjZdLoJ22uqtsJZM66RDZ4Upar HGNieAtci/nTkeTUabcZUy1DFsAPEIW+lH0zGB9J6ry8jcjZEjHVMUhmSyJ1GtEO4qrg J99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8CS82FfkB9JXdRghUtrClaDPpv2xNpqImOYlNcTMsds=; b=t2yZxXPa0cCs0SxvCXpKNJcwg79pHLLwOvoIlFD2UCGtS0+CpJuBBdZDSHBJZe5uXd DzYL5AUb59f82KpOd37aprx03eNOxbzSW9s5RMw9gsqTrFsfelMtMIb8fftW/9pTZz91 EUBbQSLzfrm8mSqhW4f2kBkK9jmNQO2BjqG8ICE6R6QyVoQVl5Eg23gGCArWiEgi/l5S wxZ25j51sFCZz6w7zyGEdejoaNvKCPbBr9cM6RweqVNKN4ELwqn41dzKOg2Bo7HwrZMo COw+FJS+tAGTuTxg1Y7AqCCGIr2k7Q+qTXMBcJKHDLPfNxm+tNBApZ5lplKPeX4Qk3t9 oL5Q== X-Gm-Message-State: AJcUukfTJhfypm+iBhvcYRQEUz1bI0t+RF0gNbag1zNfyKvLPLM2eyBZ +zoDkLF3FTJggfnP/5o2xIMnTw== X-Google-Smtp-Source: ALg8bN6y08t2TiSlj9ZLMMw5Vf4PCnC81mD3hKc21/MMcFpGtAP3e9tvhHS5X0wxterJItfi3Qo7yw== X-Received: by 2002:a17:902:680f:: with SMTP id h15mr29632plk.40.1548201675980; Tue, 22 Jan 2019 16:01:15 -0800 (PST) Received: from localhost.localdomain (220-133-186-239.HINET-IP.hinet.net. [220.133.186.239]) by smtp.gmail.com with ESMTPSA id d13sm34741445pfd.58.2019.01.22.16.01.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 16:01:14 -0800 (PST) From: Axel Lin To: Linus Walleij Cc: Thor Thayer , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Axel Lin , stable@vger.kernel.org Subject: [PATCH v3 1/2] gpio: altera-a10sr: Set proper output level for direction_output Date: Wed, 23 Jan 2019 08:00:57 +0800 Message-Id: <20190123000058.28317-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The altr_a10sr_gpio_direction_output should set proper output level based on the value argument. Fixes: 26a48c4cc2f1 ("gpio: altera-a10sr: Add A10 System Resource Chip GPIO support.") Cc: Signed-off-by: Axel Lin Tested by: Thor Thayer Reviewed by: Thor Thayer --- v3: Add Fixes tag and cc stable v2: Based on Bartosz's comment to split the patch. 1/2 is bug fix 2/2 is coding style fix and fix checkpatch warning drivers/gpio/gpio-altera-a10sr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c index 6b11f1314248..7f9e0304b510 100644 --- a/drivers/gpio/gpio-altera-a10sr.c +++ b/drivers/gpio/gpio-altera-a10sr.c @@ -66,8 +66,10 @@ static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc, static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc, unsigned int nr, int value) { - if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) + if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) { + altr_a10sr_gpio_set(gc, nr, value); return 0; + } return -EINVAL; }