| Message ID | 20180322123500.2379-1-alexandre.belloni@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: ocelot: fix gpio direction | expand |
Hi Alexandre, On jeu., mars 22 2018, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for > output. ocelot_gpio_set_direction() got it wrong and this went unnoticed > when the driver was reworked. > > Reported-by: Gregory Clement <gregory.clement@bootlin.com> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> Thanks, Gregory > --- > drivers/pinctrl/pinctrl-ocelot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c > index a9423238471e..b5b3547fdcb2 100644 > --- a/drivers/pinctrl/pinctrl-ocelot.c > +++ b/drivers/pinctrl/pinctrl-ocelot.c > @@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev, > struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); > > regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin), > - input ? BIT(pin) : 0); > + input ? 0 : BIT(pin)); > > return 0; > } > -- > 2.16.2 >
On Thu, Mar 22, 2018 at 1:35 PM, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for > output. ocelot_gpio_set_direction() got it wrong and this went unnoticed > when the driver was reworked. > > Reported-by: Gregory Clement <gregory.clement@bootlin.com> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index a9423238471e..b5b3547fdcb2 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev, struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin), - input ? BIT(pin) : 0); + input ? 0 : BIT(pin)); return 0; }
Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for output. ocelot_gpio_set_direction() got it wrong and this went unnoticed when the driver was reworked. Reported-by: Gregory Clement <gregory.clement@bootlin.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/pinctrl/pinctrl-ocelot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)